hasufell
/
hasufell-repository
1
3
Fork 8
Code Issues 1 Pull Requests 0 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#43 neovim-gtk: version bump to 0.2.0

Merged
kapsh merged 1 commits from kapsh/hasufell-repository:nvim into master 3 years ago
Conversation 1 Commits 1 Files Changed 4
kapsh commented 3 years ago

Present version fails to build (somewhere around glib crate) and it’s too old to figure out why. Updated instead.

Tagged version unusable with current pango (redraw issues, missing command line, etc) without backported patch, although other related fixes (e.g. shifting colored characters) from https://github.com/daa84/neovim-gtk/issues/208 couldn’t apply cleanly on ths commit.

Present version fails to build (somewhere around glib crate) and it's too old to figure out why. Updated instead. Tagged version unusable with current pango (redraw issues, missing command line, etc) without backported patch, although other related fixes (e.g. shifting colored characters) from https://github.com/daa84/neovim-gtk/issues/208 couldn't apply cleanly on ths commit.
kapsh reviewed 3 years ago
kapsh left a comment

@hasufell waiting for approval or merging in, say, two weeks in case you don’t care .

packages/app-editors/neovim-gtk/neovim-gtk-scm.exheres-0
@@ -21,4 +23,3 @@
cargo_src_unpack
}

src_install() {
kapsh commented 3 years ago

Moved into exlib, build+install tested for both versions.

Moved into exlib, build+install tested for both versions.
packages/app-editors/neovim-gtk/neovim-gtk-scm.exheres-0
@@ -16,2 +16,4 @@
x11-libs/gtk+:3[>=3.22.0]
x11-libs/pango[>=1.38]
run:
gnome-desktop/gsettings-desktop-schemas
kapsh commented 3 years ago

(NeovimGtk:23745): GLib-GIO-ERROR **: 01:45:31.695: Settings schema ‘org.gnome.desktop.interface’ is not installed

(NeovimGtk:23745): GLib-GIO-ERROR **: 01:45:31.695: Settings schema 'org.gnome.desktop.interface' is not installed
packages/app-editors/neovim-gtk/neovim-gtk.exlib
@@ -15,4 +16,1 @@

src_prepare() {
default
export PREFIX=/usr
kapsh commented 3 years ago

Guess it’s fine without PREFIX set:

❯ cave files neovim-gtk
/usr
/usr/share
/usr/share/applications
/usr/share/applications/org.daa.NeovimGtk.desktop
/usr/share/icons
/usr/share/icons/hicolor
/usr/share/icons/hicolor/128x128
/usr/share/icons/hicolor/128x128/apps
/usr/share/icons/hicolor/128x128/apps/org.daa.NeovimGtk.png
/usr/share/icons/hicolor/48x48
/usr/share/icons/hicolor/48x48/apps
/usr/share/icons/hicolor/48x48/apps/org.daa.NeovimGtk.png
/usr/share/icons/hicolor/scalable
/usr/share/icons/hicolor/scalable/apps
/usr/share/icons/hicolor/scalable/apps/org.daa.NeovimGtk.png
/usr/share/icons/hicolor/symbolic
/usr/share/icons/hicolor/symbolic/apps
/usr/share/icons/hicolor/symbolic/apps/org.daa.NeovimGtk.png
/usr/share/nvim-gtk
/usr/share/nvim-gtk/runtime
/usr/share/nvim-gtk/runtime/plugin
/usr/share/nvim-gtk/runtime/plugin/nvim_gui_shim.vim
/usr/x86_64-pc-linux-gnu
/usr/x86_64-pc-linux-gnu/bin
/usr/x86_64-pc-linux-gnu/bin/nvim-gtk
Guess it's fine without PREFIX set: ``` ❯ cave files neovim-gtk /usr /usr/share /usr/share/applications /usr/share/applications/org.daa.NeovimGtk.desktop /usr/share/icons /usr/share/icons/hicolor /usr/share/icons/hicolor/128x128 /usr/share/icons/hicolor/128x128/apps /usr/share/icons/hicolor/128x128/apps/org.daa.NeovimGtk.png /usr/share/icons/hicolor/48x48 /usr/share/icons/hicolor/48x48/apps /usr/share/icons/hicolor/48x48/apps/org.daa.NeovimGtk.png /usr/share/icons/hicolor/scalable /usr/share/icons/hicolor/scalable/apps /usr/share/icons/hicolor/scalable/apps/org.daa.NeovimGtk.png /usr/share/icons/hicolor/symbolic /usr/share/icons/hicolor/symbolic/apps /usr/share/icons/hicolor/symbolic/apps/org.daa.NeovimGtk.png /usr/share/nvim-gtk /usr/share/nvim-gtk/runtime /usr/share/nvim-gtk/runtime/plugin /usr/share/nvim-gtk/runtime/plugin/nvim_gui_shim.vim /usr/x86_64-pc-linux-gnu /usr/x86_64-pc-linux-gnu/bin /usr/x86_64-pc-linux-gnu/bin/nvim-gtk ```
packages/app-editors/neovim-gtk/neovim-gtk.exlib
@@ -11,11 +11,25 @@ HOMEPAGE="https://github.com/daa84/neovim-gtk ${HOMEPAGE}"
LICENCES="GPL-3.0"
MYOPTIONS=""

BUGS_TO="hasufell@posteo.de"
kapsh commented 3 years ago

Removed from recommended metadata in 8886e87da9

Removed from recommended metadata in https://gitlab.exherbo.org/exherbo-misc/docs/-/commit/8886e87da9dfd3818892e334f2c96d83d1d6fb7d
hasufell approved these changes 3 years ago
hasufell left a comment

I’m generally not a fan of exlibs in this context (exheres should be as static as possible... code sharing is actually a problem), but doesn’t matter much.

packages/app-editors/neovim-gtk/neovim-gtk.exlib
@@ -19,0 +23,4 @@
for s in 48 128; do
insinto /usr/share/icons/hicolor/${s}x${s}/apps
newins desktop/org.daa.NeovimGtk_${s}.png org.daa.NeovimGtk.png
done
hasufell commented 3 years ago

I’m pedantic, but unset s, although it’s not needed here... I consider it good practice in bash.

I'm pedantic, but `unset s`, although it's not needed here... I consider it good practice in bash.
kapsh commented 3 years ago

As usual, I forgot to local it. Fixed.

As usual, I forgot to `local` it. Fixed.
kapsh commented 3 years ago
Poster

code sharing

Well, currently they can use similar install procedure (based on makefile revisions in tagged and master). My point here is: if that becomes problem for future versions, relevant parts can be offloaded again.

> code sharing Well, currently they can use similar install procedure (based on makefile revisions in tagged and master). My point here is: if that becomes problem for future versions, relevant parts can be offloaded again.
kapsh merged commit 38572bd717 into master 3 years ago

Reviewers

hasufell approved these changes 3 years ago
The pull request has been merged as 38572bd717.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 hasufell
Labels
Apply labels
Clear labels
bug bump improvement move
No Label
bug
bump
improvement
move
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'kapsh/hasufell-repository:nvim'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes