hasufell
/
hasufell-repository
1
3
Fork 8
Code Issues 1 Pull Requests Releases Wiki Activity

hardinfo: version bump to 0.6_pre20201223 #42

Merged
kapsh merged 1 commits from kapsh/hasufell-repository:hardinfo into master 2020-12-30 14:44:02 +00:00
Conversation 3 Commits 1 Files Changed 2 +41 -34
kapsh commented 2020-12-29 18:25:37 +00:00
Collaborator
Copy Link
No description provided.
kapsh reviewed 2020-12-29 18:35:06 +00:00
packages/app-admin/hardinfo/hardinfo-0.5.2_pre20130823.exheres-0 Outdated
@ -23,4 +0,0 @@
x11-libs/pango
"
REMOTE_IDS="github:lpereira/${PN}"
kapsh commented 2020-12-29 18:26:50 +00:00
Author
Collaborator
Copy Link

Provided by github.exlib.

Provided by github.exlib.
packages/app-admin/hardinfo/hardinfo-0.5.2_pre20130823.exheres-0 Outdated
@ -1,34 +0,0 @@
# Copyright 2016 Julian Ospald <hasufell@posteo.de>
kapsh commented 2020-12-29 18:26:32 +00:00
Author
Collaborator
Copy Link

Falls under git's threshold? Diff view works in git show -M.4.

Falls under git's threshold? Diff view works in `git show -M.4`.
packages/app-admin/hardinfo/hardinfo-0.6_pre20201223.exheres-0 Outdated
kapsh commented 2020-12-29 18:34:37 +00:00
Author
Collaborator
Copy Link

Current version failed to build (multiple declaration of something, looked like missing extern declarations required for gcc-10). Surprisingly, software is still developed and they just lagging with official release. Tracking https://github.com/lpereira/hardinfo/issues/530 for it.

Current version failed to build (multiple declaration of something, looked like missing `extern` declarations required for gcc-10). Surprisingly, software is still developed and they just lagging with official release. Tracking https://github.com/lpereira/hardinfo/issues/530 for it.
kapsh commented 2020-12-29 18:58:32 +00:00
Author
Collaborator
Copy Link

Maybe just make it scm until proper release?

Maybe just make it scm until proper release?
packages/app-admin/hardinfo/hardinfo-0.6_pre20201223.exheres-0 Outdated
@ -0,0 +12,4 @@
LICENCES="GPL-2"
SLOT="0"
PLATFORMS="~amd64 ~x86"
MYOPTIONS="gtk3"
kapsh commented 2020-12-29 18:30:02 +00:00
Author
Collaborator
Copy Link

Could be also gtk2 vs gtk3, though I think this is fine too.

GTK3 support is considered experimental, but it builds and works for me in general.

Could be also `gtk2 vs gtk3`, though I think this is fine too. GTK3 support is considered experimental, but it builds and works for me in general.
kapsh commented 2020-12-29 18:36:24 +00:00
Author
Collaborator
Copy Link

@hasufell hi, care to review this?

@hasufell hi, care to review this?
kapsh reviewed 2020-12-29 18:58:44 +00:00
packages/app-admin/hardinfo/hardinfo-0.5.2_pre20130823.exheres-0 Outdated
@ -27,4 +0,0 @@
src_prepare() {
edo sed -i \
-e '/PREFIX/s:@CMAKE_INSTALL_PREFIX@/share:@CMAKE_INSTALL_DATAROOTDIR@:' \
kapsh commented 2020-12-29 18:58:01 +00:00
Author
Collaborator
Copy Link

This and more went into patch merged while I was writing previous comments.

This and more went into patch merged while I was writing previous comments.
hasufell reviewed 2020-12-30 03:28:24 +00:00
packages/app-admin/hardinfo/hardinfo-0.6_pre20201229.exheres-0 Outdated
@ -0,0 +1,43 @@
# Copyright 2016 Julian Ospald <hasufell@posteo.de>
# Distributed under the terms of the GNU General Public License v2
GITHUB_REVISION=f6a4f52868c2404f3ad58ef04e513ffe5fa090c7
hasufell commented 2020-12-30 03:26:51 +00:00
Owner
Copy Link

This is unreliable. It would be better to have a static tarball. But you can't have everything in life, I guess.

This is unreliable. It would be better to have a static tarball. But you can't have everything in life, I guess.
hasufell commented 2020-12-30 03:28:12 +00:00
Owner
Copy Link

Also add the link to the upstream release discussion here.

Also add the link to the upstream release discussion here.
kapsh commented 2020-12-30 13:46:13 +00:00
Author
Collaborator
Copy Link

I believe this is reliable until relevant commit exists, any other caveats?

Note with link added.

I believe this is reliable until relevant commit exists, any other caveats? Note with link added.
hasufell commented 2020-12-30 14:31:48 +00:00
Owner
Copy Link

it's scm, so the tarball cannot be cached

it's scm, so the tarball cannot be cached
kapsh commented 2020-12-30 14:42:51 +00:00
Author
Collaborator
Copy Link

It is cached with rev exparam (until force_git_clone given):

-rw-r--r-- 1 paludisbuild paludisbuild 1.3M Dec 29 21:38 /var/cache/paludis/distfiles/hardinfo-f6a4f52868c2404f3ad58ef04e513ffe5fa090c7.tar.gz

It is cached with `rev` exparam (until `force_git_clone` given): `-rw-r--r-- 1 paludisbuild paludisbuild 1.3M Dec 29 21:38 /var/cache/paludis/distfiles/hardinfo-f6a4f52868c2404f3ad58ef04e513ffe5fa090c7.tar.gz`
kapsh marked this conversation as resolved
packages/app-admin/hardinfo/hardinfo-0.6_pre20201229.exheres-0 Outdated
@ -0,0 +12,4 @@
LICENCES="GPL-2"
SLOT="0"
PLATFORMS="~amd64 ~x86"
MYOPTIONS="gtk3"
hasufell commented 2020-12-30 03:27:21 +00:00
Owner
Copy Link

Gtk2 is old, let's remove this flag and force gtk3.

Gtk2 is old, let's remove this flag and force gtk3.
kapsh commented 2020-12-30 13:45:29 +00:00
Author
Collaborator
Copy Link

Sure, should be fine judging by https://github.com/lpereira/hardinfo/issues/112

Deprecation warnings triggered for both builds and I personally couldn't find guibench in gtk2 interface anyway.

Sure, should be fine judging by https://github.com/lpereira/hardinfo/issues/112 Deprecation warnings triggered for both builds and I personally couldn't find guibench in gtk2 interface anyway.
kapsh marked this conversation as resolved
kapsh reviewed 2020-12-30 14:24:51 +00:00
packages/app-admin/hardinfo/hardinfo-0.6_pre20201229.exheres-0
@ -0,0 +28,4 @@
x11-libs/gtk+:3
x11-libs/libX11
x11-libs/pango
suggestion:
kapsh commented 2020-12-30 14:24:51 +00:00
Author
Collaborator
Copy Link

Source: https://github.com/lpereira/hardinfo/issues/243

Intentionally ommited from that list:

  • lsmod, lspci, locale — usually present on sane exherbo install
  • dmidecode — currently requires running gui as root
  • net-tools — considered deprecated and iproute2 is unsupported
  • xrandr, xdpyinfo — doesn't make much difference for display info
  • lsb_release — didn't change Operating system page after installing

Also I have nothing to test ups and samba rn, and fwupd could use openrc service to run.

Source: https://github.com/lpereira/hardinfo/issues/243 Intentionally ommited from that list: * lsmod, lspci, locale — usually present on sane exherbo install * dmidecode — currently requires running gui as root * net-tools — considered deprecated and iproute2 is unsupported * xrandr, xdpyinfo — doesn't make much difference for display info * lsb_release — didn't change Operating system page after installing Also I have nothing to test ups and samba rn, and fwupd could use openrc service to run.
hasufell commented 2020-12-30 14:32:58 +00:00
Owner
Copy Link

lgtm

lgtm
kapsh commented 2020-12-30 14:43:42 +00:00
Author
Collaborator
Copy Link

lgtm

Nice, thanks for directions. I'll merge it then.

> lgtm Nice, thanks for directions. I'll merge it then.
kapsh merged commit c8ac1ca574 into master 2020-12-30 14:44:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
bump

   
improvement

   
move
No Label
bug
bump
improvement
move
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hasufell/hasufell-repository#42
No description provided.
Delete Branch "kapsh/hasufell-repository:hardinfo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?