hasufell/hasufell-repository
1
3
Fork 8
Code Issues 1 Pull Requests Releases Wiki Activity

remmina: version bump to 1.4.3 #25

Closed
kapsh wants to merge 1 commits from kapsh:remmina into master
pull from: kapsh:remmina
merge into: hasufell:master
Conversation 3 Commits 1 Files Changed 3 +41 -1
kapsh commented 2020-04-25 17:04:12 +00:00
Collaborator
Copy Link
No description provided.
kapsh reviewed 2020-04-25 17:06:14 +00:00
packages/net-misc/remmina/files/fix-share-paths.patch
@ -0,0 +1,30 @@
@ -0,0 +9,4 @@
# Kiosk Session Files
install(
FILES remmina-gnome-xsession.desktop
- DESTINATION ${CMAKE_INSTALL_PREFIX}/share/xsessions
kapsh commented 2020-04-25 17:05:10 +00:00
Author
Collaborator
Copy Link

puts .desktop files into /usr/x86_64-pc-linux-gnu/share

puts .desktop files into /usr/x86_64-pc-linux-gnu/share
hasufell commented 2020-04-26 09:26:57 +00:00
Owner
Copy Link

I'm not sure this should be REMMINA_DATADIR. The build system, last I checked, uses GNUInstallDirs. Usually for such files that are not specific to the application runtime, CMAKE_INSTALL_DATAROOTDIR is used: https://github.com/Kitware/CMake/blob/master/Modules/GNUInstallDirs.cmake#L57

I'm not sure this should be `REMMINA_DATADIR`. The build system, last I checked, uses `GNUInstallDirs`. Usually for such files that are not specific to the application runtime, CMAKE_INSTALL_DATAROOTDIR is used: https://github.com/Kitware/CMake/blob/master/Modules/GNUInstallDirs.cmake#L57
kapsh commented 2020-06-17 17:53:17 +00:00
Author
Collaborator
Copy Link

I don't know why remmina owners prefer to roll their own variable even with gnuinstalldirs in action (see https://gitlab.com/Remmina/Remmina/-/blob/master/CMakeLists.txt#L234). I'll follow your advice and try to upstream this patch and we'll see what they have to say about that.

I don't know why remmina owners prefer to roll their own variable even with gnuinstalldirs in action (see https://gitlab.com/Remmina/Remmina/-/blob/master/CMakeLists.txt#L234). I'll follow your advice and try to upstream this patch and we'll see what they have to say about that.
packages/net-misc/remmina/remmina.exlib
@ -13,6 +13,7 @@ HOMEPAGE+=" http://remmina.org/"
LICENCES="GPL-2"
MYOPTIONS="
cups
kapsh commented 2020-04-25 17:05:59 +00:00
Author
Collaborator
Copy Link

Option introduced because cups usually added this way for other packages.

Option introduced because `cups` usually added this way for other packages.
hasufell reviewed 2020-04-26 09:28:43 +00:00
packages/net-misc/remmina/files/fix-share-paths.patch
@ -0,0 +1,30 @@
Upstream: no
hasufell commented 2020-04-26 09:28:34 +00:00
Owner
Copy Link

Why not? I provided patches to upstream before. We don't want to maintain it downstream.

https://gitlab.com/Remmina/Remmina

Why not? I provided patches to upstream [before](https://github.com/FreeRDP/Remmina/commit/223fef7a99661608ae7f7aef426fbd1174878080#diff-af3b638bc2a3e6c650974192a53c7291). We don't want to maintain it downstream. https://gitlab.com/Remmina/Remmina
hasufell self-assigned this 2020-04-26 12:51:53 +00:00
hasufell added the
bug
 label 2020-04-26 12:53:19 +00:00
hasufell commented 2020-06-17 17:28:24 +00:00
Owner
Copy Link

No action, closing in a week.

No action, closing in a week.
kapsh commented 2020-06-17 17:49:16 +00:00
Author
Collaborator
Copy Link

Lol, I forgot about that one. Thanks for reminder. Probably they have another version released already, stay tuned.

Lol, I forgot about that one. Thanks for reminder. Probably they have another version released already, stay tuned.
hasufell commented 2020-06-26 12:38:26 +00:00
Owner
Copy Link

Closing.

Closing.
hasufell closed this pull request 2020-06-26 12:38:29 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
bump

   
improvement

   
move
No Label
bug
bump
improvement
move
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
hasufell
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hasufell/hasufell-repository#25
No description provided.
Delete Branch "kapsh:remmina"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?