Bump HLS to 1.4.0

Improve warnAboutHlsCompatibility
Merge remote-tracking branch 'origin/merge-requests/172'
2021-09-15 22:41:57 +02:00 · 2021-09-14 12:36:14 +02:00 · 2021-09-14 12:26:41 +02:00 · 2021-09-13 22:33:46 +02:00 · 2021-09-13 08:43:10 +02:00 · 2021-09-11 23:35:39 -04:00
4 changed files with 86 additions and 22 deletions
--- a/data/metadata/ghcup-0.0.6.yaml
+++ b/data/metadata/ghcup-0.0.6.yaml
@@ -72,7 +72,6 @@ toolRequirements:
        '( >= 7 && < 8 )':
          distroPKGs:
          - gcc
-          - gcc-c++
          - gmp
          - gmp-devel
          - make
@@ -83,7 +82,6 @@ toolRequirements:
        unknown_versioning:
          distroPKGs:
          - gcc
-          - gcc-c++
          - gmp
          - gmp-devel
          - make
@@ -96,7 +94,6 @@ toolRequirements:
        unknown_versioning:
          distroPKGs:
          - gcc
-          - gcc-c++
          - gmp
          - gmp-devel
          - make
@@ -111,14 +108,15 @@ toolRequirements:
          - binutils-gold
          - curl
          - gcc
-          - g++
          - gmp-dev
-          - ncurses-dev
+          - libc-dev
          - libffi-dev
          - make
-          - xz
-          - tar
+          - musl-dev
+          - ncurses-dev
          - perl
+          - tar
+          - xz
          notes: ''
      Linux_UnknownLinux:
        unknown_versioning:
@@ -2357,9 +2355,7 @@ ghcupDownloads:
          Linux_Alpine:
            unknown_versioning: *hls-120-64
    1.3.0:
-      viTags:
-        - Recommended
-        - Latest
+      viTags: []
      viChangeLog: https://github.com/haskell/haskell-language-server/blob/master/ChangeLog.md#130
      viPostInstall: *hls-post-install
      viArch:
@@ -2378,6 +2374,28 @@ ghcupDownloads:
              dlHash: 46aac7be888e29a9907cf56698c1ce1475c148b5e6cc099513e9ef74a0520dcf
          Linux_Alpine:
            unknown_versioning: *hls-130-64
+    1.4.0:
+      viTags:
+        - Recommended
+        - Latest
+      viChangeLog: https://github.com/haskell/haskell-language-server/blob/master/ChangeLog.md#140
+      viPostInstall: *hls-post-install
+      viArch:
+        A_64:
+          Linux_UnknownLinux:
+            unknown_versioning: &hls-140-64
+              dlUri: https://github.com/haskell/haskell-language-server/releases/download/1.4.0/haskell-language-server-Linux-1.4.0.tar.gz
+              dlHash: f93c114441911ccce55649702adc9553cb4c9f953c37878321d2806a3525fee8
+          Darwin:
+            unknown_versioning:
+              dlUri: https://github.com/haskell/haskell-language-server/releases/download/1.4.0/haskell-language-server-macOS-1.4.0.tar.gz
+              dlHash: a7f0ac6be93ffb08cc239e5f5fead99b061061825f99566c1be33ee60cab62a4
+          Windows:
+            unknown_versioning:
+              dlUri: https://github.com/haskell/haskell-language-server/releases/download/1.4.0/haskell-language-server-Windows-1.4.0.tar.gz
+              dlHash: 0ec77cee750037b7a0ede817b46a913a702821f4098c6a858bcb686cb30f7efd
+          Linux_Alpine:
+            unknown_versioning: *hls-140-64
  Stack:
    2.5.1:
      viTags:
--- a/data/metadata/ghcup-0.0.7.yaml
+++ b/data/metadata/ghcup-0.0.7.yaml
@@ -72,7 +72,6 @@ toolRequirements:
        '( >= 7 && < 8 )':
          distroPKGs:
          - gcc
-          - gcc-c++
          - gmp
          - gmp-devel
          - make
@@ -83,7 +82,6 @@ toolRequirements:
        unknown_versioning:
          distroPKGs:
          - gcc
-          - gcc-c++
          - gmp
          - gmp-devel
          - make
@@ -96,7 +94,6 @@ toolRequirements:
        unknown_versioning:
          distroPKGs:
          - gcc
-          - gcc-c++
          - gmp
          - gmp-devel
          - make
@@ -109,7 +106,6 @@ toolRequirements:
        unknown_versioning:
          distroPKGs:
          - gcc
-          - g++
          - gmp
          - gmp-devel
          - make
@@ -125,14 +121,15 @@ toolRequirements:
          - binutils-gold
          - curl
          - gcc
-          - g++
          - gmp-dev
-          - ncurses-dev
+          - libc-dev
          - libffi-dev
          - make
-          - xz
-          - tar
+          - musl-dev
+          - ncurses-dev
          - perl
+          - tar
+          - xz
          notes: ''
      Linux_UnknownLinux:
        unknown_versioning:
@@ -2419,9 +2416,7 @@ ghcupDownloads:
          Linux_Alpine:
            unknown_versioning: *hls-120-64
    1.3.0:
-      viTags:
-        - Recommended
-        - Latest
+      viTags: []
      viChangeLog: https://github.com/haskell/haskell-language-server/blob/master/ChangeLog.md#130
      viPostInstall: *hls-post-install
      viArch:
@@ -2440,6 +2435,28 @@ ghcupDownloads:
              dlHash: 46aac7be888e29a9907cf56698c1ce1475c148b5e6cc099513e9ef74a0520dcf
          Linux_Alpine:
            unknown_versioning: *hls-130-64
+    1.4.0:
+      viTags:
+        - Recommended
+        - Latest
+      viChangeLog: https://github.com/haskell/haskell-language-server/blob/master/ChangeLog.md#140
+      viPostInstall: *hls-post-install
+      viArch:
+        A_64:
+          Linux_UnknownLinux:
+            unknown_versioning: &hls-140-64
+              dlUri: https://github.com/haskell/haskell-language-server/releases/download/1.4.0/haskell-language-server-Linux-1.4.0.tar.gz
+              dlHash: f93c114441911ccce55649702adc9553cb4c9f953c37878321d2806a3525fee8
+          Darwin:
+            unknown_versioning:
+              dlUri: https://github.com/haskell/haskell-language-server/releases/download/1.4.0/haskell-language-server-macOS-1.4.0.tar.gz
+              dlHash: a7f0ac6be93ffb08cc239e5f5fead99b061061825f99566c1be33ee60cab62a4
+          Windows:
+            unknown_versioning:
+              dlUri: https://github.com/haskell/haskell-language-server/releases/download/1.4.0/haskell-language-server-Windows-1.4.0.tar.gz
+              dlHash: 0ec77cee750037b7a0ede817b46a913a702821f4098c6a858bcb686cb30f7efd
+          Linux_Alpine:
+            unknown_versioning: *hls-140-64
  Stack:
    2.5.1:
      viTags:
--- a/lib/GHCup.hs
+++ b/lib/GHCup.hs
@@ -868,6 +868,8 @@ setGHC ver sghc = do
  -- create symlink for share dir
  when (isNothing . _tvTarget $ ver) $ lift $ symlinkShareDir ghcdir verS

+  when (sghc == SetGHCOnly) $ lift warnAboutHlsCompatibility
+
  pure ver

 where
@@ -978,6 +980,8 @@ setHLS ver = do

  lift $ createLink destL wrapper

+  lift warnAboutHlsCompatibility
+
  pure ()


@@ -1010,6 +1014,31 @@ setStack ver = do
  pure ()


+-- | Warn if the installed and set HLS is not compatible with the installed and
+-- set GHC version.
+warnAboutHlsCompatibility :: ( MonadReader env m
+                             , HasDirs env
+                             , HasLog env
+                             , MonadThrow m
+                             , MonadCatch m
+                             , MonadIO m
+                             )
+                          => m ()
+warnAboutHlsCompatibility = do
+  supportedGHC <- hlsGHCVersions
+  currentGHC   <- fmap _tvVersion <$> ghcSet Nothing
+  currentHLS   <- hlsSet
+
+  case (currentGHC, currentHLS) of
+    (Just gv, Just hv) | gv `notElem` supportedGHC -> do
+      logWarn $
+        "GHC " <> T.pack (prettyShow gv) <> " is not compatible with " <>
+        "Haskell Language Server " <> T.pack (prettyShow hv) <> "." <> "\n" <>
+        "Haskell IDE support may not work until this is fixed." <> "\n" <>
+        "Install a different HLS version, or install and set one of the following GHCs:" <> "\n" <>
+        T.pack (prettyShow supportedGHC)
+        
+    _ -> return ()

    ------------------
    --[ List tools ]--
--- a/lib/GHCup/Utils.hs
+++ b/lib/GHCup/Utils.hs
@@ -475,7 +475,7 @@ hlsGHCVersions = do
        . splitOn "~"
        )
      bins
-  pure . rights . concat . maybeToList $ vers
+  pure . sortBy (flip compare) . rights . concat . maybeToList $ vers


 -- | Get all server binaries for an hls version, if any.
Author	SHA1	Message	Date
Julian Ospald	0f14dee72a	Bump HLS to 1.4.0	2021-09-15 22:41:57 +02:00
Julian Ospald	ae2031174e	Improve warnAboutHlsCompatibility	2021-09-14 12:36:14 +02:00
Julian Ospald	c163278c64	Merge remote-tracking branch 'origin/merge-requests/172'	2021-09-14 12:26:41 +02:00
Julian Ospald	d10133f06f	Clean up toolRequirements	2021-09-13 22:33:46 +02:00
Julian Ospald	4377fc663e	Merge branch 'opencollective'	2021-09-13 08:43:10 +02:00
Chris Smith	737f72f90f	Lint fix.	2021-09-11 23:35:39 -04:00
Chris Smith	c3aab65521	Rewording	2021-09-11 23:24:21 -04:00
Chris Smith	972474f79a	Add version numbers to error message. Fixes after formatting changes.	2021-09-11 23:17:14 -04:00
Julian Ospald	bc64d2ade0	Apply 3 suggestion(s) to 1 file(s)	2021-09-12 03:09:36 +00:00
Chris Smith	eddda55fe6	Fix hlint warnings	2021-09-11 19:57:42 -04:00
Chris Smith	13aca91231	Add a warning when the installed HLS and GHC versions are not compatible. This is triggered when: 1. The user has just set either the GHC or HLS version. 2. There is an HLS version set (so some GHC version is compatible). 3. There is a GHC version. 4. The HLS version doesn't support that GHC version. Fixes #234	2021-09-11 19:33:27 -04:00