hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "Fix #556 Remove duplicate error messages from clang++"

Browse Source 
This reverts commit 164c4efb32.
This commit is contained in:
w0rp 2017-05-20 12:57:41 +01:00
parent 0646b2861f
commit d012fd1f09
2 changed files with 2 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
autoload/ale/handlers/gcc.vim
View File

@ -99,17 +99,12 @@ function! ale#handlers#gcc#HandleGCCFormat(buffer, lines) abort
continue
endif
let l:obj = {
call add(l:output, {
\ 'lnum': l:match[2] + 0,
\ 'col': l:match[3] + 0,
\ 'type': l:match[4] =~# 'error' ? 'E' : 'W',
\ 'text': s:RemoveUnicodeQuotes(l:match[5]),
\}
" clang++ and some other tools can output duplicated errors.
if empty(l:output) || l:output[-1] != l:obj
call add(l:output, l:obj)
endif
\})
endif
endfor

26
test/handler/test_gcc_handler.vader
View File

@ -94,29 +94,3 @@ Execute(The GCC handler shouldn't complain about #pragma once for headers):
\ ale#handlers#gcc#HandleGCCFormat(347, [
\ '<stdin>:1:1: warning: #pragma once in main file [enabled by default]',
\ ])
Execute(The GCC handler should eliminate duplicated clang errors):
AssertEqual
\ [
\ {'lnum': 2, 'col': 10, 'type': 'E', 'text': '''a.h'' file not found'},
\ {'lnum': 4, 'col': 10, 'type': 'E', 'text': 'empty filename'},
\ ],
\ ale#handlers#gcc#HandleGCCFormat(347, [
\ '<stdin>:2:10: fatal error: ''a.h'' file not found',
\ '#include "a.h"',
\ ' ^~~~~',
\ '',
\ '<stdin>:2:10: fatal error: ''a.h'' file not found',
\ '#include "a.h"',
\ ' ^~~~~',
\ '',
\ '<stdin>:4:10: error: empty filename',
\ '',
\ '<stdin>:4:10: error: empty filename',
\ '#include ""',
\ ' ^',
\ '',
\ '<stdin>:4:10: error: empty filename',
\ '#include ""',
\ ' ^',
\ ])