Merge pull request #50 from jwilliams108/linter-phpcs

adding phpcs linter
This commit is contained in:
w0rp 2016-10-06 12:18:47 +02:00 committed by GitHub
commit 0466ae942c
3 changed files with 60 additions and 2 deletions

View File

@ -37,7 +37,7 @@ name. That seems to be the fairest way to arrange this table.
| HTML | [tidy](http://www.html-tidy.org/) | | HTML | [tidy](http://www.html-tidy.org/) |
| JavaScript | [eslint](http://eslint.org/), [jscs](http://jscs.info/), [jshint](http://jshint.com/) | | JavaScript | [eslint](http://eslint.org/), [jscs](http://jscs.info/), [jshint](http://jshint.com/) |
| JSON | [jsonlint](http://zaa.ch/jsonlint/) | | JSON | [jsonlint](http://zaa.ch/jsonlint/) |
| PHP | [php -l](https://secure.php.net/) | | PHP | [php -l](https://secure.php.net/), [phpcs](https://github.com/squizlabs/PHP_CodeSniffer) |
| Python | [flake8](http://flake8.pycqa.org/en/latest/) | | Python | [flake8](http://flake8.pycqa.org/en/latest/) |
| Ruby | [rubocop](https://github.com/bbatsov/rubocop) | | Ruby | [rubocop](https://github.com/bbatsov/rubocop) |
| SASS | [sass-lint](https://www.npmjs.com/package/sass-lint) | | SASS | [sass-lint](https://www.npmjs.com/package/sass-lint) |

58
ale_linters/php/phpcs.vim Normal file
View File

@ -0,0 +1,58 @@
" Author: jwilliams108 <https://github.com/jwilliams108>
" Description: phpcs for PHP files
if exists('g:loaded_ale_linters_php_phpcs')
finish
endif
let g:loaded_ale_linters_php_phpcs = 1
function! ale_linters#php#phpcs#GetCommand(buffer)
let command = 'phpcs -s --report=emacs --stdin-path=%s'
" This option can be set to change the standard used by phpcs
if exists('g:ale_linters_php_phpcs_standard')
let command .= ' --standard=' . g:ale_linters_php_phpcs_standard
endif
return command
endfunction
function! ale_linters#php#phpcs#Handle(buffer, lines)
" Matches against lines like the following:
"
" /path/to/some-filename.php:18:3: error - Line indented incorrectly; expected 4 spaces, found 2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
let pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\) - \(.\+\) \(\(.\+\)\)$'
let output = []
for line in a:lines
let l:match = matchlist(line, pattern)
if len(l:match) == 0
continue
endif
let text = l:match[4]
let type = l:match[3]
" vcol is Needed to indicate that the column is a character.
call add(output, {
\ 'bufnr': a:buffer,
\ 'lnum': l:match[1] + 0,
\ 'vcol': 0,
\ 'col': l:match[2] + 0,
\ 'text': text,
\ 'type': type ==# 'warning' ? 'W' : 'E',
\ 'nr': -1,
\})
endfor
return output
endfunction
call ALEAddLinter('php', {
\ 'name': 'phpcs',
\ 'executable': 'phpcs',
\ 'command_callback': 'ale_linters#php#phpcs#GetCommand',
\ 'callback': 'ale_linters#php#phpcs#Handle',
\})

View File

@ -46,7 +46,7 @@ The following languages and tools are supported.
* HTML: 'tidy' * HTML: 'tidy'
* JavaScript: 'eslint', 'jscs', 'jshint' * JavaScript: 'eslint', 'jscs', 'jshint'
* JSON: 'jsonlint' * JSON: 'jsonlint'
* PHP: 'php' (-l flag) * PHP: 'php' (-l flag), 'phpcs'
* Python: 'flake8' * Python: 'flake8'
* Ruby: 'rubocop' * Ruby: 'rubocop'
* SASS: 'sasslint' * SASS: 'sasslint'