From e7a7b31d3c8314a7b84f56d7fb7df619929cfd43 Mon Sep 17 00:00:00 2001 From: jwilliams108 Date: Thu, 6 Oct 2016 20:11:19 +1100 Subject: [PATCH 1/2] adding phpcs linter --- ale_linters/php/phpcs.vim | 58 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 ale_linters/php/phpcs.vim diff --git a/ale_linters/php/phpcs.vim b/ale_linters/php/phpcs.vim new file mode 100644 index 0000000..62517c9 --- /dev/null +++ b/ale_linters/php/phpcs.vim @@ -0,0 +1,58 @@ +" Author: jwilliams108 +" Description: phpcs for PHP files + +if exists('g:loaded_ale_linters_php_phpcs') + finish +endif + +let g:loaded_ale_linters_php_phpcs = 1 + +function! ale_linters#php#phpcs#GetCommand(buffer) + let command = 'phpcs -s --report=emacs --stdin-path=%s' + + " This option can be set to change the standard used by phpcs + if exists('g:ale_linters_php_phpcs_standard') + let command .= ' --standard=' . g:ale_linters_php_phpcs_standard + endif + + return command +endfunction + +function! ale_linters#php#phpcs#Handle(buffer, lines) + " Matches against lines like the following: + " + " /path/to/some-filename.php:18:3: error - Line indented incorrectly; expected 4 spaces, found 2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact) + let pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\) - \(.\+\) \(\(.\+\)\)$' + let output = [] + + for line in a:lines + let l:match = matchlist(line, pattern) + + if len(l:match) == 0 + continue + endif + + let text = l:match[4] + let type = l:match[3] + + " vcol is Needed to indicate that the column is a character. + call add(output, { + \ 'bufnr': a:buffer, + \ 'lnum': l:match[1] + 0, + \ 'vcol': 0, + \ 'col': l:match[2] + 0, + \ 'text': text, + \ 'type': type ==# 'warning' ? 'W' : 'E', + \ 'nr': -1, + \}) + endfor + + return output +endfunction + +call ALEAddLinter('php', { +\ 'name': 'phpcs', +\ 'executable': 'phpcs', +\ 'command_callback': 'ale_linters#php#phpcs#GetCommand', +\ 'callback': 'ale_linters#php#phpcs#Handle', +\}) From 04533038ef2ae9520ddeffa88d0bf987aa3c9167 Mon Sep 17 00:00:00 2001 From: jwilliams108 Date: Thu, 6 Oct 2016 21:05:48 +1100 Subject: [PATCH 2/2] updating README and doc with reference to phpcs linter --- README.md | 2 +- doc/ale.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 574e08b..03bca3c 100644 --- a/README.md +++ b/README.md @@ -37,7 +37,7 @@ name. That seems to be the fairest way to arrange this table. | HTML | [tidy](http://www.html-tidy.org/) | | JavaScript | [eslint](http://eslint.org/), [jscs](http://jscs.info/), [jshint](http://jshint.com/) | | JSON | [jsonlint](http://zaa.ch/jsonlint/) | -| PHP | [php -l](https://secure.php.net/) | +| PHP | [php -l](https://secure.php.net/), [phpcs](https://github.com/squizlabs/PHP_CodeSniffer) | | Python | [flake8](http://flake8.pycqa.org/en/latest/) | | Ruby | [rubocop](https://github.com/bbatsov/rubocop) | | SASS | [sass-lint](https://www.npmjs.com/package/sass-lint) | diff --git a/doc/ale.txt b/doc/ale.txt index e32df32..7cc9a03 100644 --- a/doc/ale.txt +++ b/doc/ale.txt @@ -46,7 +46,7 @@ The following languages and tools are supported. * HTML: 'tidy' * JavaScript: 'eslint', 'jscs', 'jshint' * JSON: 'jsonlint' -* PHP: 'php' (-l flag) +* PHP: 'php' (-l flag), 'phpcs' * Python: 'flake8' * Ruby: 'rubocop' * SASS: 'sasslint'