Prevent popup blink in case events hide/show come together

This commit is contained in:
daa 2018-03-31 19:56:44 +03:00
parent 9ef88bc30b
commit 82c7f0818a
2 changed files with 47 additions and 2 deletions

View File

@ -19,9 +19,11 @@ impl NvimHandler {
NvimHandler { shell: shell } NvimHandler { shell: shell }
} }
fn nvim_cb(&self, method: &str, params: Vec<Value>) { fn nvim_cb(&self, method: &str, mut params: Vec<Value>) {
match method { match method {
"redraw" => { "redraw" => {
redraw_handler::remove_uneeded_events(&mut params);
self.safe_call(move |ui| { self.safe_call(move |ui| {
let ui = &mut ui.borrow_mut(); let ui = &mut ui.borrow_mut();
let mut repaint_mode = RepaintMode::Nothing; let mut repaint_mode = RepaintMode::Nothing;

View File

@ -116,7 +116,7 @@ pub fn call_gui_event(
}, },
"Command" => { "Command" => {
ui.on_command(args); ui.on_command(args);
}, }
_ => return Err(format!("Unsupported event {}({:?})", method, args)), _ => return Err(format!("Unsupported event {}({:?})", method, args)),
} }
Ok(()) Ok(())
@ -247,6 +247,30 @@ pub fn call(
Ok(repaint_mode) Ok(repaint_mode)
} }
// menu content update call popupmenu_hide followed by popupmenu_show
// this generates unneded hide event
// so in case we get both events, just romove one
pub fn remove_uneeded_events(params: &mut Vec<Value>) {
let mut show_popup_finded = false;
let mut to_remove = Vec::new();
for (idx, val) in params.iter().enumerate().rev() {
if let Some(args) = val.as_array() {
match args[0].as_str() {
Some("popupmenu_show") => show_popup_finded = true,
Some("popupmenu_hide") if show_popup_finded => {
to_remove.push(idx);
}
_ => (),
}
}
}
to_remove.iter().for_each(|&idx| {
params.remove(idx);
});
}
pub struct CompleteItem<'a> { pub struct CompleteItem<'a> {
pub word: &'a str, pub word: &'a str,
pub kind: &'a str, pub kind: &'a str,
@ -266,3 +290,22 @@ impl<'a> CompleteItem<'a> {
.collect() .collect()
} }
} }
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_remove_popup_menu_hide() {
// remove only first hide
let mut params = vec![
Value::from(vec![Value::from("popupmenu_hide")]),
Value::from(vec![Value::from("popupmenu_show")]),
Value::from(vec![Value::from("popupmenu_hide")]),
];
remove_uneeded_events(&mut params);
assert_eq!(2, params.len());
}
}