TESTS: also test directories with no permissions at all

test/Spec.hs

@@ -29,8 +29,13 @@ import System.Exit
 import System.Process
 import System.Posix.Files.ByteString
   (
-    groupReadMode
+    accessModes
+  , groupExecuteMode
+  , groupReadMode
+  , nullFileMode
+  , otherExecuteMode
   , otherReadMode
+  , ownerExecuteMode
   , ownerReadMode
   , setFileMode
   , unionFileModes
@@ -43,7 +48,7 @@ import System.Posix.Files.ByteString
 
 
 main :: IO ()
-main = hspec $ before_ fixPermissions $ do
+main = hspec $ before_ fixPermissions $ after_ revertPermissions $ do
   let tests = [copyFileSpec
               , copyDirRecursiveSpec
               , createDirSpec
@@ -59,8 +64,7 @@ main = hspec $ before_ fixPermissions $ do
 
   -- TODO: deleteFile, deleteDir, deleteDirRecursive, getDirsFiles, getFileType
   where
-    fixPermissions = do
+    noWriteDirs =  ["test/copyFileSpec/outputDirNoWrite"
-      let dirlist =  ["test/copyFileSpec/outputDirNoWrite"
                    ,"test/copyDirRecursiveSpec/noWritePerm"
                    ,"test/createDirSpec/noWritePerms"
                    ,"test/createRegularFileSpec/noWritePerms"
@@ -68,7 +72,20 @@ main = hspec $ before_ fixPermissions $ do
                    ,"test/moveFile/noWritePerm"
                    ,"test/recreateSymlinkSpec/noWritePerm"
                    ]
-      sequence_ $ fmap noWritable dirlist
+    noPermsDirs =  ["test/copyFileSpec/noPerms"
+                   ,"test/copyDirRecursiveSpec/noPerms"
+                   ,"test/createDirSpec/noPerms"
+                   ,"test/createRegularFileSpec/noPerms"
+                   ,"test/renameFile/noPerms"
+                   ,"test/moveFile/noPerms"
+                   ,"test/recreateSymlinkSpec/noPerms"
+                   ]
+    fixPermissions = do
+      sequence_ $ fmap noWritableDirPerms noWriteDirs
+      sequence_ $ fmap noPerms noPermsDirs
+    revertPermissions = do
+      sequence_ $ fmap normalDirPerms noWriteDirs
+      sequence_ $ fmap normalDirPerms noPermsDirs
 
 
     -------------
@@ -105,6 +122,19 @@ copyFileSpec =
         `shouldThrow`
         (\e -> ioeGetErrorType e == PermissionDenied)
 
+    it "copyFile, cannot open output directory" $
+      copyFile' "test/copyFileSpec/inputFile"
+                "test/copyFileSpec/noPerms/outputFile"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
+    it "copyFile, cannot open source directory" $
+      copyFile' "test/copyFileSpec/noPerms/inputFile"
+                "test/copyFileSpec/outputFile"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
+
     it "copyFile, wrong input type (symlink)" $
       copyFile' "test/copyFileSpec/inputFileSymL"
                 "test/copyFileSpec/outputFile"
@@ -166,6 +196,18 @@ copyDirRecursiveSpec =
         `shouldThrow`
         (\e -> ioeGetErrorType e == PermissionDenied)
 
+    it "copyDirRecursive, cannot open destination dir" $
+      copyDirRecursive' "test/copyDirRecursiveSpec/inputDir"
+                        "test/copyDirRecursiveSpec/noPerms/foo"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
+    it "copyDirRecursive, cannot open source dir" $
+      copyDirRecursive' "test/copyDirRecursiveSpec/noPerms/inputDir"
+                        "test/copyDirRecursiveSpec/foo"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
     it "copyDirRecursive, destination dir already exists" $
       copyDirRecursive' "test/copyDirRecursiveSpec/inputDir"
                         "test/copyDirRecursiveSpec/alreadyExistsD"
@@ -217,6 +259,11 @@ createDirSpec =
         `shouldThrow`
         (\e -> ioeGetErrorType e == PermissionDenied)
 
+    it "createDir, can't open destination directory" $
+      createDir' "test/createDirSpec/noPerms/newDir"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
     it "createDir, destination directory already exists" $
       createDir' "test/createDirSpec/alreadyExists"
         `shouldThrow`
@@ -237,6 +284,11 @@ createRegularFileSpec =
         `shouldThrow`
         (\e -> ioeGetErrorType e == PermissionDenied)
 
+    it "createRegularFile, can't write to destination directory" $
+      createRegularFile' "test/createRegularFileSpec/noPerms/newDir"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
     it "createRegularFile, destination file already exists" $
       createRegularFile' "test/createRegularFileSpec/alreadyExists"
         `shouldThrow`
@@ -277,6 +329,18 @@ renameFileSpec =
         `shouldThrow`
         (\e -> ioeGetErrorType e == PermissionDenied)
 
+    it "renameFile, can't open destination directory" $
+      renameFile' "test/renameFile/myFile"
+                  "test/renameFile/noPerms/renamedFile"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
+    it "renameFile, can't open source directory" $
+      renameFile' "test/renameFile/noPerms/myFile"
+                  "test/renameFile/renamedFile"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
     -- custom failures --
     it "renameFile, destination file already exists" $
       renameFile' "test/renameFile/myFile"
@@ -331,6 +395,18 @@ moveFileSpec =
         `shouldThrow`
         (\e -> ioeGetErrorType e == PermissionDenied)
 
+    it "moveFile, can't open destination directory" $
+      moveFile' "test/moveFile/myFile"
+                "test/moveFile/noPerms/movedFile"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
+    it "moveFile, can't open source directory" $
+      moveFile' "test/moveFile/noPerms/myFile"
+                "test/moveFile/movedFile"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
     -- custom failures --
     it "moveFile, destination file already exists" $
       moveFile' "test/moveFile/myFile"
@@ -383,6 +459,18 @@ recreateSymlinkSpec =
         `shouldThrow`
         (\e -> ioeGetErrorType e == PermissionDenied)
 
+    it "recreateSymLink, can't open destination directory" $
+      recreateSymlink' "test/recreateSymlinkSpec/myFileL"
+                       "test/recreateSymlinkSpec/noPerms/movedFile"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
+    it "recreateSymLink, can't open source directory" $
+      recreateSymlink' "test/recreateSymlinkSpec/noPerms/myFileL"
+                       "test/recreateSymlinkSpec/movedFile"
+        `shouldThrow`
+        (\e -> ioeGetErrorType e == PermissionDenied)
+
     it "recreateSymLink, destination file already exists" $
       recreateSymlink' "test/recreateSymlinkSpec/myFileL"
                        "test/recreateSymlinkSpec/alreadyExists"
@@ -483,12 +571,30 @@ recreateSymlink' inputFileP outputFileP = do
   whenM (doesFileExist outputFile) (deleteFile outputFile)
 
 
-noWritable :: ByteString -> IO ()
+noWritableDirPerms :: ByteString -> IO ()
-noWritable path = do
+noWritableDirPerms path = do
   pwd <- fromJust <$> getEnv "PWD" >>= P.parseAbs
   file <- (pwd P.</>) <$> P.parseRel path
   setFileMode (P.fromAbs file) perms
   where
     perms =            ownerReadMode
+      `unionFileModes` ownerExecuteMode
       `unionFileModes` groupReadMode
+      `unionFileModes` groupExecuteMode
       `unionFileModes` otherReadMode
+      `unionFileModes` otherExecuteMode
+
+
+noPerms :: ByteString -> IO ()
+noPerms path = do
+  pwd <- fromJust <$> getEnv "PWD" >>= P.parseAbs
+  file <- (pwd P.</>) <$> P.parseRel path
+  setFileMode (P.fromAbs file) nullFileMode
+
+
+normalDirPerms :: ByteString -> IO ()
+normalDirPerms path = do
+  pwd <- fromJust <$> getEnv "PWD" >>= P.parseAbs
+  file <- (pwd P.</>) <$> P.parseRel path
+  setFileMode (P.fromAbs file) accessModes
+

test/copyDirRecursiveSpec/noPerms/inputDir/bar/inputFile3

@@ -0,0 +1,8 @@
+dadasasddas
+sda
+
+!!1
+sda
+
+
+11

test/copyDirRecursiveSpec/noPerms/inputDir/foo/inputFile1

@@ -0,0 +1 @@
+dadasasddas

test/copyDirRecursiveSpec/noPerms/inputDir/inputFile2

@@ -0,0 +1,4 @@
+dadasasddas
+das
+sda
+sda

test/recreateSymlinkSpec/noPerms/myFile

@@ -0,0 +1,4 @@
+ads
+sad
+das
+sda

test/recreateSymlinkSpec/noPerms/myFileL

@@ -0,0 +1 @@
+myFile