From 4c8bb37e56337e39c0872ed22d9497f8a23f4371 Mon Sep 17 00:00:00 2001 From: hasufell Date: Sat, 10 May 2014 22:58:51 +0200 Subject: [PATCH] Fix error handling in get_normalized_scale_factor() --- src/half_edge.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/half_edge.c b/src/half_edge.c index d85743a..febfb03 100644 --- a/src/half_edge.c +++ b/src/half_edge.c @@ -85,17 +85,22 @@ HE_vert *find_center(HE_obj const * const obj) * to the size of 1. * * @param obj the object we want to scale - * @return the corresponding scale factor + * @return the corresponding scale factor, -1 on error */ float get_normalized_scale_factor(HE_obj const * const obj) { - float max = obj->vertices[0].x + - obj->vertices[0].y + obj->vertices[0].z; - float min = obj->vertices[0].x + - obj->vertices[0].y + obj->vertices[0].z; - + float max; + float min; uint32_t i; + if (!obj) + return -1; + + max = obj->vertices[0].x + + obj->vertices[0].y + obj->vertices[0].z; + min = obj->vertices[0].x + + obj->vertices[0].y + obj->vertices[0].z; + for (i = 0; i < obj->vc; i++) { if ((obj->vertices[i].x + obj->vertices[i].y +