Fix HLS CI

.github/workflows/install-bindist.sh

@@ -2,20 +2,17 @@
 set -x
 set -eo pipefail
 
+. .github/workflows/common.sh
+
 export GHCUP_INSTALL_BASE_PREFIX=$RUNNER_TEMP/foobarbaz
 
 curl --proto '=https' --tlsv1.2 -sSf https://get-ghcup.haskell.org | sh
 
-source $GHCUP_INSTALL_BASE_PREFIX/.ghcup/env || source ~/.bashrc
+source "$GHCUP_INSTALL_BASE_PREFIX"/.ghcup/env || source "$HOME/.bashrc"
 
 ghcup --version
 which ghcup | grep foobarbaz
 
-# oh no
-if [ "${TOOL}" = "hls" ] ; then
-	ghcup -v --url-source=file:$METADATA_FILE install ghc --set 9.2.4
-fi
-
 ghcup -v --url-source=file:$METADATA_FILE install $TOOL --set $VERSION
 
 mkdir -p /tmp/install-bindist-ci
@@ -31,8 +28,60 @@ EOF
 
 case $TOOL in
 	hls)
-		haskell-language-server-wrapper --version
-		haskell-language-server-wrapper typecheck main.hs
+		ghcup install cabal latest
+		ghcup install ghc --set recommended
+		cabal update
+
+		test_package="bytestring-0.11.1.0"
+		test_module="Data/ByteString.hs"
+
+		create_cradle() {
+			echo "cradle:" > hie.yaml
+			echo "  cabal:" >> hie.yaml
+		}
+
+		enter_test_package() {
+			local tmp_dir
+			tmp_dir=$(mktempdir)
+			cd "$tmp_dir"
+			cabal unpack "${test_package}"
+			cd "${test_package}"
+		}
+
+		# For all HLS GHC versions and the wrapper, run 'typecheck'
+		# over the $test_module
+		test_all_hls() {
+			local bin
+			local bin_noexe
+			local bindir
+			local hls
+			bindir=$1
+
+			for hls in "${bindir}/"haskell-language-server-* ; do
+				bin=${hls##*/}
+				bin_noexe=${bin/.exe/}
+				if ! [[ "${bin_noexe}" =~ "haskell-language-server-wrapper" ]] && ! [[ "${bin_noexe}" =~ "~" ]] && ! [[ "${bin_noexe}" =~ ".shim" ]] ; then
+					if ghcup install ghc --set "${bin_noexe/haskell-language-server-/}" ; then
+						"${hls}" typecheck "${test_module}" || fail "failed to typecheck with HLS for GHC ${bin_noexe/haskell-language-server-/}"
+					else
+						fail "GHCup failed to install GHC ${bin_noexe/haskell-language-server-/}"
+					fi
+					ghcup rm ghc "${bin_noexe/haskell-language-server-/}"
+				fi
+			done
+			"$bindir/haskell-language-server-wrapper${ext}" typecheck "${test_module}" || fail "failed to typecheck with HLS wrapper"
+		}
+
+        enter_test_package
+        create_cradle
+		case "$(uname -s)" in
+			MSYS_*|MINGW*)
+				test_all_hls "$(dirname "$(which ghcup)")"
+				;;
+			*)
+				test_all_hls "$(ghcup whereis bindir)"
+			   ;;
+	    esac
 		;;
     ghc)
 		ghc --version