Fix unpacking of bindists with hardinks pointing to themselves

https://github.com/vmchale/libarchive/issues/14
https://github.com/libarchive/libarchive/issues/1381

3rdparty/libarchive/c/archive_write_disk_posix.c

@@ -546,6 +546,7 @@ _archive_write_disk_header(struct archive *_a, struct archive_entry *entry)
 {
 	struct archive_write_disk *a = (struct archive_write_disk *)_a;
 	struct fixup_entry *fe;
+	const char *linkname;
 	int ret, r;
 
 	archive_check_magic(&a->archive, ARCHIVE_WRITE_DISK_MAGIC,
@@ -590,6 +591,17 @@ _archive_write_disk_header(struct archive *_a, struct archive_entry *entry)
 	if (ret != ARCHIVE_OK)
 		return (ret);
 
+	/*
+	 * Check if we have a hardlink that points to itself.
+	 */
+	linkname = archive_entry_hardlink(a->entry);
+	if (linkname != NULL && strcmp(a->name, linkname) == 0) {
+		archive_set_error(&a->archive, ARCHIVE_ERRNO_MISC,
+		    "Skipping hardlink pointing to itself: %s",
+		    a->name);
+		return (ARCHIVE_WARN);
+	}
+
 	/*
 	 * Query the umask so we get predictable mode settings.
 	 * This gets done on every call to _write_header in case the

app/ghcup/Main.hs

@@ -1033,7 +1033,10 @@ Report bugs at <https://gitlab.haskell.org/haskell/ghcup-hs/issues>|]
                       runLogger
                         ($(logError) [i|Error fetching download info: #{e}|])
                       exitWith (ExitFailure 2)
-          runLogger $ checkForUpdates dls pfreq
+
+          case optCommand of
+            Upgrade _ _ -> pure ()
+            _ -> runLogger $ checkForUpdates dls pfreq
 
 
 

ghcup-0.0.2.json

@@ -851,9 +851,9 @@
           "A_64": {
             "Linux_Alpine": {
               "unknown_versioning": {
-                "dlHash": "ec6d0417822c3bfafc7aea0b0402294901231bc5d72dd17a2b849e3f44850695",
+                "dlHash": "76cedc5a9ed9fe259bc7e279defa789f833c5d7144a83915ba8b67371aca481b",
                 "dlSubdir": "ghc-8.6.5",
-                "dlUri": "https://github.com/redneb/ghc-alt-libc/releases/download/ghc-8.6.5-musl/ghc-8.6.5-x86_64-unknown-linux-musl.tar.xz"
+                "dlUri": "https://files.hasufell.de/ghc/ghc-8.6.5-x86_64-alpine-linux.tar.xz"
               }
             },
             "FreeBSD": {
@@ -1253,6 +1253,20 @@
       "8.8.4": {
         "viArch": {
           "A_64": {
+            "Linux_Alpine": {
+              "unknown_versioning": {
+                "dlHash": "5b8dbe2f2430bd66ddc0572fa5a5b5201b9fb7c9a66e13fd5bfb377a5a891bac",
+                "dlSubdir": "ghc-8.8.4",
+                "dlUri": "https://files.hasufell.de/ghc/ghc-8.8.4-x86_64-alpine-linux.tar.xz"
+              }
+            },
+            "FreeBSD": {
+              "unknown_versioning": {
+                "dlHash": "8cebe5ccf454e82acd1ff52ca57590d1ab0f3f44a981b46257ec12158c8c447e",
+                "dlSubdir": "ghc-8.8.4",
+                "dlUri": "https://files.hasufell.de/ghc/ghc-8.8.4-x86_64-portbld-freebsd.tar.xz"
+              }
+            },
             "Linux_Debian": {
               "unknown_versioning": {
                 "dlHash": "4862559d221153caf978f4bf2c15a82c114d1e1f43b298b2ecff2ac94b586d20",
@@ -1333,13 +1347,6 @@
             }
           },
           "A_32": {
-            "FreeBSD": {
-              "unknown_versioning": {
-                "dlHash": "8cebe5ccf454e82acd1ff52ca57590d1ab0f3f44a981b46257ec12158c8c447e",
-                "dlSubdir": "ghc-8.8.4",
-                "dlUri": "https://files.hasufell.de/ghc/ghc-8.8.4-x86_64-portbld-freebsd.tar.xz"
-              }
-            },
             "Linux_Debian": {
               "unknown_versioning": {
                 "dlHash": "43dd954910c9027694312cef0aabc7774d102d0422b7172802cfb72f7d5da3a0",

lib/GHCup/Data/GHCupDownloads.hs

@@ -652,11 +652,11 @@ ghc_865_64_darwin = DownloadInfo
   (Just [rel|ghc-8.6.5|])
   "dfc1bdb1d303a87a8552aa17f5b080e61351f2823c2b99071ec23d0837422169"
 
-ghc_865_64_musl :: DownloadInfo
+ghc_865_64_alpine :: DownloadInfo
-ghc_865_64_musl = DownloadInfo
+ghc_865_64_alpine = DownloadInfo
-  [uri|https://github.com/redneb/ghc-alt-libc/releases/download/ghc-8.6.5-musl/ghc-8.6.5-x86_64-unknown-linux-musl.tar.xz|]
+  [uri|https://files.hasufell.de/ghc/ghc-8.6.5-x86_64-alpine-linux.tar.xz|]
   (Just [rel|ghc-8.6.5|])
-  "ec6d0417822c3bfafc7aea0b0402294901231bc5d72dd17a2b849e3f44850695"
+  "76cedc5a9ed9fe259bc7e279defa789f833c5d7144a83915ba8b67371aca481b"
 
 ghc_865_32_musl :: DownloadInfo
 ghc_865_32_musl = DownloadInfo
@@ -894,6 +894,12 @@ ghc_884_64_freebsd = DownloadInfo
   (Just [rel|ghc-8.8.4|])
   "8cebe5ccf454e82acd1ff52ca57590d1ab0f3f44a981b46257ec12158c8c447e"
 
+ghc_884_64_alpine :: DownloadInfo
+ghc_884_64_alpine = DownloadInfo
+  [uri|https://files.hasufell.de/ghc/ghc-8.8.4-x86_64-alpine-linux.tar.xz|]
+  (Just [rel|ghc-8.8.4|])
+  "5b8dbe2f2430bd66ddc0572fa5a5b5201b9fb7c9a66e13fd5bfb377a5a891bac"
+
 
 
     -----------------
@@ -1702,7 +1708,7 @@ ghcupDownloads = M.fromList
                       ]
                     )
                   , (Darwin      , M.fromList [(Nothing, ghc_865_64_darwin)])
-                  , (Linux Alpine, M.fromList [(Nothing, ghc_865_64_musl)])
+                  , (Linux Alpine, M.fromList [(Nothing, ghc_865_64_alpine)])
                   , (FreeBSD     , M.fromList [(Nothing, ghc_865_64_freebsd)])
                   ]
                 )
@@ -1920,6 +1926,8 @@ ghcupDownloads = M.fromList
                       ]
                     )
                   , (Darwin, M.fromList [(Nothing, ghc_884_64_darwin)])
+                  , (Linux Alpine, M.fromList [(Nothing, ghc_884_64_alpine)])
+                  , (FreeBSD     , M.fromList [(Nothing, ghc_884_64_freebsd)])
                   ]
                 )
               , ( A_32
@@ -1930,7 +1938,6 @@ ghcupDownloads = M.fromList
                   , (Linux Ubuntu, M.fromList [(Nothing, ghc_884_32_deb9)])
                   , (Linux Mint  , M.fromList [(Nothing, ghc_884_32_deb9)])
                   , (Linux Debian, M.fromList [(Nothing, ghc_884_32_deb9)])
-                  , (FreeBSD     , M.fromList [(Nothing, ghc_884_64_freebsd)])
                   ]
                 )
               ]