Remove URLSource from Settings

This commit is contained in:
Julian Ospald 2020-03-17 18:39:01 +01:00
parent f5a2db6719
commit 8a1bd45ffe
6 changed files with 38 additions and 50 deletions

View File

@ -161,7 +161,7 @@ validateTarballs dls = do
where where
downloadAll dli = do downloadAll dli = do
let settings = Settings True GHCupURL False let settings = Settings True False
let runLogger = myLoggerT LoggerConfig { lcPrintDebug = True let runLogger = myLoggerT LoggerConfig { lcPrintDebug = True
, colorOutter = B.hPut stderr , colorOutter = B.hPut stderr
, rawOutter = (\_ -> pure ()) , rawOutter = (\_ -> pure ())

View File

@ -455,7 +455,6 @@ platformParser s' = case MP.parse (platformP <* MP.eof) "" (T.pack s') of
toSettings :: Options -> Settings toSettings :: Options -> Settings
toSettings Options {..} = toSettings Options {..} =
let cache = optCache let cache = optCache
urlSource = maybe GHCupURL OwnSource optUrlSource
noVerify = optNoVerify noVerify = optNoVerify
in Settings { .. } in Settings { .. }
@ -592,7 +591,8 @@ main = do
( runLogger ( runLogger
. flip runReaderT settings . flip runReaderT settings
. runE @'[JSONError , DownloadFailed] . runE @'[JSONError , DownloadFailed]
$ liftE getDownloads $ liftE
$ getDownloads (maybe GHCupURL OwnSource optUrlSource)
) )
>>= \case >>= \case
VRight r -> pure r VRight r -> pure r
@ -607,7 +607,7 @@ main = do
void void
$ (runInstTool $ do $ (runInstTool $ do
v <- liftE $ fromVersion dls instVer GHC v <- liftE $ fromVersion dls instVer GHC
liftE $ installGHCBin dls v Nothing liftE $ installGHCBin dls v optPlatform
) )
>>= \case >>= \case
VRight _ -> runLogger VRight _ -> runLogger
@ -630,7 +630,7 @@ Check the logs at ~/ghcup/logs and the build directory #{tmpdir} for more clues.
void void
$ (runInstTool $ do $ (runInstTool $ do
v <- liftE $ fromVersion dls instVer Cabal v <- liftE $ fromVersion dls instVer Cabal
liftE $ installCabalBin dls v Nothing liftE $ installCabalBin dls v optPlatform
) )
>>= \case >>= \case
VRight _ -> runLogger VRight _ -> runLogger

View File

@ -404,7 +404,7 @@ rmGHCVer ver = do
------------------ ------------------
getDebugInfo :: (MonadLogger m, MonadCatch m, MonadReader Settings m, MonadIO m) getDebugInfo :: (MonadLogger m, MonadCatch m, MonadIO m)
=> Excepts => Excepts
'[NoCompatiblePlatform , NoCompatibleArch , DistroNotFound] '[NoCompatiblePlatform , NoCompatibleArch , DistroNotFound]
m m
@ -414,7 +414,6 @@ getDebugInfo = do
diBinDir <- liftIO $ ghcupBinDir diBinDir <- liftIO $ ghcupBinDir
diGHCDir <- liftIO $ ghcupGHCBaseDir diGHCDir <- liftIO $ ghcupGHCBaseDir
diCacheDir <- liftIO $ ghcupCacheDir diCacheDir <- liftIO $ ghcupCacheDir
diURLSource <- lift $ getUrlSource
diArch <- lE getArchitecture diArch <- lE getArchitecture
diPlatform <- liftE $ getPlatform diPlatform <- liftE $ getPlatform
pure $ DebugInfo { .. } pure $ DebugInfo { .. }

View File

@ -93,14 +93,13 @@ getDownloads :: ( FromJSONKey Tool
, FromJSON VersionInfo , FromJSON VersionInfo
, MonadIO m , MonadIO m
, MonadCatch m , MonadCatch m
, MonadReader Settings m
, MonadLogger m , MonadLogger m
, MonadThrow m , MonadThrow m
, MonadFail m , MonadFail m
) )
=> Excepts '[JSONError , DownloadFailed] m GHCupDownloads => URLSource
getDownloads = do -> Excepts '[JSONError , DownloadFailed] m GHCupDownloads
urlSource <- lift getUrlSource getDownloads urlSource = do
lift $ $(logDebug) [i|Receiving download info from: #{urlSource}|] lift $ $(logDebug) [i|Receiving download info from: #{urlSource}|]
case urlSource of case urlSource of
GHCupURL -> do GHCupURL -> do
@ -204,11 +203,7 @@ getDownloads = do
getDownloadInfo :: ( MonadLogger m getDownloadInfo :: (MonadLogger m, MonadCatch m, MonadIO m)
, MonadCatch m
, MonadIO m
, MonadReader Settings m
)
=> GHCupDownloads => GHCupDownloads
-> Tool -> Tool
-> Version -> Version

View File

@ -105,7 +105,6 @@ data URLSource = GHCupURL
data Settings = Settings data Settings = Settings
{ cache :: Bool { cache :: Bool
, urlSource :: URLSource
, noVerify :: Bool , noVerify :: Bool
} }
deriving Show deriving Show
@ -116,7 +115,6 @@ data DebugInfo = DebugInfo
, diBinDir :: Path Abs , diBinDir :: Path Abs
, diGHCDir :: Path Abs , diGHCDir :: Path Abs
, diCacheDir :: Path Abs , diCacheDir :: Path Abs
, diURLSource :: URLSource
, diArch :: Architecture , diArch :: Architecture
, diPlatform :: PlatformResult , diPlatform :: PlatformResult
} }
@ -141,4 +139,3 @@ data PlatformRequest = PlatformRequest
, _rVersion :: Maybe Versioning , _rVersion :: Maybe Versioning
} }
deriving (Eq, Show) deriving (Eq, Show)

View File

@ -277,9 +277,6 @@ getRecommended av tool = headOf folded $ getTagged av tool Recommended
----------------------- -----------------------
getUrlSource :: MonadReader Settings m => m URLSource
getUrlSource = ask <&> urlSource
getCache :: MonadReader Settings m => m Bool getCache :: MonadReader Settings m => m Bool
getCache = ask <&> cache getCache = ask <&> cache