Revert "Fix tests for Cabal <= 1.16"

The problem the reverted commit tried to fix seems to have been just a
symptom of another root cause that was later fixed as the problem does
not seem to occur anymore even without this changeset also this
changeset broke cabal sandboxes with ghc < 7.8.

Fix #262

This reverts commit 8741323f5b.

Conflicts:
	Language/Haskell/GhcMod/GhcPkg.hs
This commit is contained in:
Daniel Gröber
2014-05-19 01:20:58 +02:00
parent fcc3b46415
commit 241c7946fc
4 changed files with 5 additions and 33 deletions

View File

@@ -1,4 +1,4 @@
{-# LANGUAGE CPP, ScopedTypeVariables #-}
{-# LANGUAGE ScopedTypeVariables #-}
module CabalApiSpec where
@@ -36,15 +36,9 @@ spec = do
ghcOptions = ghcOptions res
, includeDirs = map (toRelativeDir dir) (includeDirs res)
}
#if MIN_VERSION_Cabal(1,18,0)
if ghcVersion < 706
then ghcOptions res' `shouldContain` ["-global-package-conf", "-no-user-package-conf","-package-conf",cwd </> "test/data/.cabal-sandbox/i386-osx-ghc-7.6.3-packages.conf.d","-XHaskell98"]
else ghcOptions res' `shouldContain` ["-global-package-db", "-no-user-package-db","-package-db",cwd </> "test/data/.cabal-sandbox/i386-osx-ghc-7.6.3-packages.conf.d","-XHaskell98"]
#else
if ghcVersion < 706
then ghcOptions res' `shouldContain` ["-global-package-conf", "-user-package-conf","-XHaskell98"]
else ghcOptions res' `shouldContain` ["-global-package-db", "-user-package-db","-XHaskell98"]
#endif
includeDirs res' `shouldBe` ["test/data","test/data/dist/build","test/data/dist/build/autogen","test/data/subdir1/subdir2","test/data/test"]
(pkgName `map` depPackages res') `shouldContain` ["Cabal"]

View File

@@ -1,4 +1,3 @@
{-# LANGUAGE CPP #-}
module CradleSpec where
import Control.Applicative
@@ -32,11 +31,7 @@ spec = do
cradleCurrentDir = "test" </> "data" </> "subdir1" </> "subdir2"
, cradleRootDir = "test" </> "data"
, cradleCabalFile = Just ("test" </> "data" </> "cabalapi.cabal")
#if MIN_VERSION_Cabal(1,18,0)
, cradlePkgDbStack = [GlobalDb, PackageDb (cwd </> "test/data/.cabal-sandbox/i386-osx-ghc-7.6.3-packages.conf.d")]
#else
, cradlePkgDbStack = [GlobalDb, UserDb]
#endif
}
it "works even if a sandbox config file is broken" $ do
withDirectory "test/data/broken-sandbox" $ \dir -> do

View File

@@ -1,8 +1,6 @@
{-# LANGUAGE CPP #-}
module GhcPkgSpec where
import Language.Haskell.GhcMod.GhcPkg
import Language.Haskell.GhcMod.Types
import System.Directory
import System.FilePath ((</>))
@@ -10,12 +8,7 @@ import Test.Hspec
spec :: Spec
spec = do
describe "getPackageDbStack" $ do
#if !MIN_VERSION_Cabal(1,18,0)
it "does not include a sandbox with Cabal < 1.18" $ do
cwd <- getCurrentDirectory
getPackageDbStack cwd `shouldReturn` [GlobalDb, UserDb]
#endif
describe "getSandboxDb" $ do
it "parses a config file and extracts sandbox package db" $ do
cwd <- getCurrentDirectory
pkgDb <- getSandboxDb "test/data/"