8f6044b8b6
Implements suggestions and recommendations suggested by the first review of the "Advance C# linter based on mcs -t:module (#952)" pull request. - Clarifies and simplifies description of linters and options - Added links to help file and marked the mcsc linter as to be run only when file in buffer is saved or loaded. - Added comments to the mcsc.vim file to clarify code - removed type checks considered not necessary be reviewer. - addresses findings by vader - removed call to getcwd and cd in vim script - handler expands file names relative to route of source tree into absolute pathes. Fixes errors not being marked when vim is started from subdirectory of source tree. - implements tests for mcs.vim and mcsc.vim linter
35 lines
880 B
Plaintext
35 lines
880 B
Plaintext
Before:
|
|
runtime ale_linters/cs/mcs.vim
|
|
|
|
After:
|
|
call ale#linter#Reset()
|
|
|
|
Execute(The mcs handler should handle cannot find symbol errors):
|
|
AssertEqual
|
|
\ [
|
|
\ {
|
|
\ 'lnum': 12,
|
|
\ 'col' : 29,
|
|
\ 'text': 'error CS1001: ; expected',
|
|
\ 'type': 'E',
|
|
\ },
|
|
\ {
|
|
\ 'lnum': 101,
|
|
\ 'col': 0,
|
|
\ 'text': 'error CS1028: Unexpected processor directive (no #if for this #endif)',
|
|
\ 'type': 'E',
|
|
\ },
|
|
\ {
|
|
\ 'lnum': 10,
|
|
\ 'col': 12,
|
|
\ 'text': 'warning CS0123: some warning',
|
|
\ 'type': 'W',
|
|
\ },
|
|
\ ],
|
|
\ ale_linters#cs#mcs#Handle(347, [
|
|
\ 'Tests.cs(12,29): error CS1001: ; expected',
|
|
\ 'Tests.cs(101,0): error CS1028: Unexpected processor directive (no #if for this #endif)',
|
|
\ 'Tests.cs(10,12): warning CS0123: some warning',
|
|
\ 'Compilation failed: 2 error(s), 1 warnings',
|
|
\ ])
|