ab0e76dbd5
* Use rubocop's JSON output format (resolves #339) Rubocop's emacs formatter seems to have changed format in some not-so-ancient version. The JSON formatter should provide a more stable interface than parsing lines with a regex. The JSON formatter was introduced in mid-2013, so it should be safe to assume available in any reasonably-modern environment. The oldest currently-supported version of ruby (according to ruby-lang.org) was not supported by rubocop until 2014. * Rubocop: Use global function for GetType * Rubocop: Use scope prefix in GetType * Rubocop: Update command_callback test * Rubocop: add end_col to Handle
62 lines
1.8 KiB
VimL
62 lines
1.8 KiB
VimL
" Author: ynonp - https://github.com/ynonp, Eddie Lebow https://github.com/elebow
|
|
" Description: RuboCop, a code style analyzer for Ruby files
|
|
|
|
function! ale_linters#ruby#rubocop#GetCommand(buffer) abort
|
|
let l:executable = ale#handlers#rubocop#GetExecutable(a:buffer)
|
|
let l:exec_args = l:executable =~? 'bundle$'
|
|
\ ? ' exec rubocop'
|
|
\ : ''
|
|
|
|
return ale#Escape(l:executable) . l:exec_args
|
|
\ . ' --format json --force-exclusion '
|
|
\ . ale#Var(a:buffer, 'ruby_rubocop_options')
|
|
\ . ' --stdin ' . bufname(a:buffer)
|
|
endfunction
|
|
|
|
function! ale_linters#ruby#rubocop#Handle(buffer, lines) abort
|
|
if len(a:lines) == 0
|
|
return []
|
|
endif
|
|
|
|
let l:errors = json_decode(a:lines[0])
|
|
|
|
let l:output = []
|
|
|
|
for l:error in l:errors['files'][0]['offenses']
|
|
let l:start_col = l:error['location']['column'] + 0
|
|
call add(l:output, {
|
|
\ 'lnum': l:error['location']['line'] + 0,
|
|
\ 'col': l:start_col,
|
|
\ 'end_col': l:start_col + l:error['location']['length'] - 1,
|
|
\ 'text': l:error['message'],
|
|
\ 'type': ale_linters#ruby#rubocop#GetType(l:error['severity']),
|
|
\})
|
|
endfor
|
|
|
|
return l:output
|
|
endfunction
|
|
|
|
function! ale_linters#ruby#rubocop#GetType(severity) abort
|
|
if a:severity ==? 'refactor'
|
|
return 'W'
|
|
elseif a:severity ==? 'convention'
|
|
return 'W'
|
|
elseif a:severity ==? 'warning'
|
|
return 'W'
|
|
elseif a:severity ==? 'error'
|
|
return 'E'
|
|
elseif a:severity ==? 'fatal'
|
|
return 'E'
|
|
else
|
|
echo 'Rubocop offense type unrecognized by ALE: ' + a:severity
|
|
return ''
|
|
endif
|
|
endfunction
|
|
|
|
call ale#linter#Define('ruby', {
|
|
\ 'name': 'rubocop',
|
|
\ 'executable_callback': 'ale#handlers#rubocop#GetExecutable',
|
|
\ 'command_callback': 'ale_linters#ruby#rubocop#GetCommand',
|
|
\ 'callback': 'ale_linters#ruby#rubocop#Handle',
|
|
\})
|