#810 Ignore output which isn't JSON for brakeman

ale_linters/ruby/brakeman.vim

@@ -9,7 +9,12 @@ function! ale_linters#ruby#brakeman#Handle(buffer, lines) abort
         return []
     endif
 
+    try
         let l:result = json_decode(join(a:lines, ''))
+    catch /E474/
+        " Ignore invalid JSON
+        return []
+    endtry
 
     let l:output = []
 

test/handler/test_brakeman_handler.vader

@@ -1,20 +1,15 @@
 Before:
-    " Switch to the test rails directory.
+  call ale#test#SetDirectory('/testplugin/test/handler')
-    let b:path = getcwd()
+  cd ..
-    silent! cd /testplugin/test/handler
-    cd ../ruby_fixtures/valid_rails_app/app/models
 
   runtime ale_linters/ruby/brakeman.vim
 
 After:
-    " Switch back to whatever directory it was that we started on.
+  call ale#test#RestoreDirectory()
-    silent! 'cd ' . fnameescape(b:path)
-    unlet! b:path
-
   call ale#linter#Reset()
 
 Execute(The brakeman handler should parse JSON correctly):
-  silent file! thing.rb
+  call ale#test#SetFilename('ruby_fixtures/valid_rails_app/app/models/thing.rb')
 
   AssertEqual
   \  [
@@ -78,3 +73,10 @@ Execute(The brakeman handler should parse JSON correctly when there is no output
   \ [],
   \ ale_linters#ruby#brakeman#Handle(347, [
   \ ])
+  \
+Execute(The brakeman handler should handle garbage output):
+  AssertEqual
+  \ [],
+  \ ale_linters#ruby#brakeman#Handle(347, [
+  \   'No such command in 2.4.1 of ruby',
+  \ ])