hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix an exception with notes with no previous message

Browse Source
This commit is contained in:
w0rp 2017-10-25 23:43:09 +01:00
parent 7eb16836d0
commit da365134b5
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
autoload/ale/handlers/gcc.vim
View File

@ -82,8 +82,12 @@ function! ale#handlers#gcc#HandleGCCFormat(buffer, lines) abort
" If the 'error type' is a note, make it detail related to " If the 'error type' is a note, make it detail related to
" the previous error parsed in output " the previous error parsed in output
if l:match[4] is# 'note' if l:match[4] is# 'note'
let l:output[-1]['detail'] = get(l:output[-1], 'detail', '') if !empty(l:output)
\ . s:RemoveUnicodeQuotes(l:match[0]) . "\n" let l:output[-1]['detail'] =
\ get(l:output[-1], 'detail', '')
\ . s:RemoveUnicodeQuotes(l:match[0]) . "\n"
endif
continue continue
endif endif

8
test/handler/test_gcc_handler.vader
View File

@ -128,3 +128,11 @@ Execute(The GCC handler should handle syntax errors):
\ '<stdin>:4: error: ''cat'' was not declared in this scope', \ '<stdin>:4: error: ''cat'' was not declared in this scope',
\ '<stdin>:12: error: expected `;'' before ''o''', \ '<stdin>:12: error: expected `;'' before ''o''',
\ ]) \ ])
Execute(The GCC handler should handle notes with no previous message):
AssertEqual
\ [],
\ ale#handlers#gcc#HandleGCCFormat(347, [
\ '<stdin>:1:1: note: x',
\ '<stdin>:1:1: note: x',
\ ])