Merge pull request #695 from jsivak/feature/fix_multiple_parens

Change regex to better handle messages with multiple groups of parentheses.
This commit is contained in:
w0rp 2017-06-26 09:25:56 +01:00 committed by GitHub
commit d2ec53f817
2 changed files with 8 additions and 1 deletions

View File

@ -36,7 +36,7 @@ function! ale_linters#python#pylint#Handle(buffer, lines) abort
" Matches patterns like the following: " Matches patterns like the following:
" "
" test.py:4:4: W0101 (unreachable) Unreachable code " test.py:4:4: W0101 (unreachable) Unreachable code
let l:pattern = '\v^[^:]+:(\d+):(\d+): ([[:alnum:]]+) \((.*)\) (.*)$' let l:pattern = '\v^[^:]+:(\d+):(\d+): ([[:alnum:]]+) \(([^(]*)\) (.*)$'
let l:output = [] let l:output = []
for l:match in ale#util#GetMatches(a:lines, l:pattern) for l:match in ale#util#GetMatches(a:lines, l:pattern)

View File

@ -38,6 +38,12 @@ Execute(pylint handler parsing, translating columns to 1-based index):
\ 'text': 'W0101: Unreachable code (unreachable)', \ 'text': 'W0101: Unreachable code (unreachable)',
\ 'type': 'W', \ 'type': 'W',
\ }, \ },
\ {
\ 'lnum': 7,
\ 'col': 33,
\ 'text': 'W0702: No exception type(s) specified (bare-except)',
\ 'type': 'W',
\ },
\ ], \ ],
\ ale_linters#python#pylint#Handle(bufnr(''), [ \ ale_linters#python#pylint#Handle(bufnr(''), [
\ 'No config file found, using default configuration', \ 'No config file found, using default configuration',
@ -47,6 +53,7 @@ Execute(pylint handler parsing, translating columns to 1-based index):
\ 'test.py:2:0: C0111 (missing-docstring) Missing function docstring', \ 'test.py:2:0: C0111 (missing-docstring) Missing function docstring',
\ 'test.py:3:4: E0103 (not-in-loop) ''break'' not properly in loop', \ 'test.py:3:4: E0103 (not-in-loop) ''break'' not properly in loop',
\ 'test.py:4:4: W0101 (unreachable) Unreachable code', \ 'test.py:4:4: W0101 (unreachable) Unreachable code',
\ 'test.py:7:32: W0702 (bare-except) No exception type(s) specified',
\ '', \ '',
\ '------------------------------------------------------------------', \ '------------------------------------------------------------------',
\ 'Your code has been rated at 0.00/10 (previous run: 2.50/10, -2.50)', \ 'Your code has been rated at 0.00/10 (previous run: 2.50/10, -2.50)',