hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #1158 from rhysd/redpen-error-code

Browse Source 
redpen: Use 'code' key to show validator
This commit is contained in:
w0rp 2017-11-21 12:33:19 +00:00 committed by GitHub
commit ce2986cfa5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
autoload/ale/handlers/redpen.vim
View File

@ -8,8 +8,9 @@ function! ale#handlers#redpen#HandleRedpenOutput(buffer, lines) abort
let l:output = [] let l:output = []
for l:err in l:res.errors for l:err in l:res.errors
let l:item = { let l:item = {
\ 'text': l:err.message . ' (' . l:err.validator . ')', \ 'text': l:err.message,
\ 'type': 'W', \ 'type': 'W',
\ 'code': l:err.validator,
\} \}
if has_key(l:err, 'startPosition') if has_key(l:err, 'startPosition')
let l:item.lnum = l:err.startPosition.lineNum let l:item.lnum = l:err.startPosition.lineNum
@ -19,6 +20,8 @@ function! ale#handlers#redpen#HandleRedpenOutput(buffer, lines) abort
let l:item.end_col = l:err.endPosition.offset let l:item.end_col = l:err.endPosition.offset
endif endif
else else
" Fallback to a whole sentence region when a region is not
" specified by the error.
let l:item.lnum = l:err.lineNum let l:item.lnum = l:err.lineNum
let l:item.col = l:err.sentenceStartColumnNum + 1 let l:item.col = l:err.sentenceStartColumnNum + 1
endif endif

6
test/handler/test_redpen_handler.vader
View File

@ -12,14 +12,16 @@ Execute(redpen handler should handle errors output):
\ 'col': 10, \ 'col': 10,
\ 'end_lnum': 1, \ 'end_lnum': 1,
\ 'end_col': 15, \ 'end_col': 15,
\ 'text': 'Found possibly misspelled word "plugin". (Spelling)', \ 'text': 'Found possibly misspelled word "plugin".',
\ 'type': 'W', \ 'type': 'W',
\ 'code': 'Spelling',
\ }, \ },
\ { \ {
\ 'lnum': 1, \ 'lnum': 1,
\ 'col': 1, \ 'col': 1,
\ 'text': 'Found possibly misspelled word "NeoVim". (Spelling)', \ 'text': 'Found possibly misspelled word "NeoVim".',
\ 'type': 'W', \ 'type': 'W',
\ 'code': 'Spelling',
\ }, \ },
\ ], \ ],
\ ale#handlers#redpen#HandleRedpenOutput(bufnr(''), [ \ ale#handlers#redpen#HandleRedpenOutput(bufnr(''), [