hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Simplify the sandbox check, to save on execution time

Browse Source
This commit is contained in:
w0rp 2017-05-25 17:23:16 +01:00
parent 6f76a840f0
commit c31cd12bdd
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
autoload/ale/util.vim
View File

@ -80,13 +80,11 @@ endfunction
" See :help sandbox " See :help sandbox
function! ale#util#InSandbox() abort function! ale#util#InSandbox() abort
try try
call setbufvar('%', '', '') function! s:SandboxCheck() abort
endfunction
catch /^Vim\%((\a\+)\)\=:E48/ catch /^Vim\%((\a\+)\)\=:E48/
" E48 is the sandbox error. " E48 is the sandbox error.
return 1 return 1
catch
" If we're not in a sandbox, we'll get another error about an
" invalid buffer variable name.
endtry endtry
return 0 return 0

6
test/test_sandbox_execution.vader
View File

@ -27,12 +27,18 @@ After:
delfunction TestCallback delfunction TestCallback
call ale#linter#Reset() call ale#linter#Reset()
let g:ale_buffer_info = {} let g:ale_buffer_info = {}
unlet! b:in_sandbox
Given foobar (Some imaginary filetype): Given foobar (Some imaginary filetype):
foo foo
bar bar
baz baz
Execute(ale#util#InSandbox should return 1 when in a sandbox):
sandbox let b:in_sandbox = ale#util#InSandbox()
Assert b:in_sandbox, 'ale#util#InSandbox() returned 0 for a sandbox command'
Execute(ALE shouldn't blow up when run from a sandbox): Execute(ALE shouldn't blow up when run from a sandbox):
AssertEqual 'foobar', &filetype AssertEqual 'foobar', &filetype