hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix #1251 - Handle an empty list in the line callback when NeoVim crashes

Browse Source
This commit is contained in:
w0rp 2017-12-26 18:15:51 +00:00
parent 48cae6afc4
commit c165c7c5d1
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
autoload/ale/job.vim
View File

@ -36,7 +36,7 @@ function! ale#job#JoinNeovimOutput(job, last_line, data, mode, callback) abort
let l:lines[0] = a:last_line . l:lines[0] let l:lines[0] = a:last_line . l:lines[0]
let l:new_last_line = a:data[-1] let l:new_last_line = a:data[-1]
else else
let l:new_last_line = a:last_line . a:data[0] let l:new_last_line = a:last_line . get(a:data, 0, '')
endif endif
for l:line in l:lines for l:line in l:lines

6
test/test_line_join.vader
View File

@ -17,6 +17,12 @@ After:
delfunction LineCallback delfunction LineCallback
delfunction RawCallback delfunction RawCallback
Execute (ALE should handle empty Lists for the lines):
let g:last_line = ale#job#JoinNeovimOutput(1, '', [], 'nl', function('LineCallback'))
AssertEqual [], g:lines
AssertEqual '', g:last_line
Execute (ALE should pass on full lines for NeoVim): Execute (ALE should pass on full lines for NeoVim):
let g:last_line = ale#job#JoinNeovimOutput(1, '', ['x', 'y', ''], 'nl', function('LineCallback')) let g:last_line = ale#job#JoinNeovimOutput(1, '', ['x', 'y', ''], 'nl', function('LineCallback'))