hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

#416 Escape the tslint command

Browse Source
This commit is contained in:
w0rp 2018-03-18 16:48:28 +00:00
parent b08fdd16b8
commit bdd8d2399f
No known key found for this signature in database
GPG Key ID: 0FC1ECAA8C81CD83
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ale_linters/typescript/tslint.vim
View File

@ -70,7 +70,7 @@ function! ale_linters#typescript#tslint#GetCommand(buffer) abort
\ : '' \ : ''
return ale#path#BufferCdString(a:buffer) return ale#path#BufferCdString(a:buffer)
\ . ale_linters#typescript#tslint#GetExecutable(a:buffer) \ . ale#Escape(ale_linters#typescript#tslint#GetExecutable(a:buffer))
\ . ' --format json' \ . ' --format json'
\ . l:tslint_config_option \ . l:tslint_config_option
\ . l:tslint_rules_option \ . l:tslint_rules_option

16
test/command_callback/test_tslint_command_callback.vader
View File

@ -17,7 +17,10 @@ Before:
After: After:
Restore Restore
unlet! b:ale_typescript_tslint_executable
unlet! b:ale_typescript_tslint_config_path
unlet! b:ale_typescript_tslint_rules_dir unlet! b:ale_typescript_tslint_rules_dir
unlet! b:ale_typescript_tslint_use_global
call ale#test#RestoreDirectory() call ale#test#RestoreDirectory()
call ale#linter#Reset() call ale#linter#Reset()
@ -25,7 +28,7 @@ After:
Execute(The default tslint command should be correct): Execute(The default tslint command should be correct):
AssertEqual AssertEqual
\ 'cd ' . ale#Escape(expand('%:p:h')) . ' && ' \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
\ . 'tslint --format json %t', \ . ale#Escape('tslint') . ' --format json %t',
\ ale_linters#typescript#tslint#GetCommand(bufnr('')) \ ale_linters#typescript#tslint#GetCommand(bufnr(''))
Execute(The rules directory option should be included if set): Execute(The rules directory option should be included if set):
@ -33,7 +36,16 @@ Execute(The rules directory option should be included if set):
AssertEqual AssertEqual
\ 'cd ' . ale#Escape(expand('%:p:h')) . ' && ' \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
\ . 'tslint --format json' \ . ale#Escape('tslint') . ' --format json'
\ . ' -r ' . ale#Escape('/foo/bar') \ . ' -r ' . ale#Escape('/foo/bar')
\ . ' %t', \ . ' %t',
\ ale_linters#typescript#tslint#GetCommand(bufnr('')) \ ale_linters#typescript#tslint#GetCommand(bufnr(''))
Execute(The executable should be configurable and escaped):
let b:ale_typescript_tslint_executable = 'foo bar'
AssertEqual 'foo bar', ale_linters#typescript#tslint#GetExecutable(bufnr(''))
AssertEqual
\ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
\ . ale#Escape('foo bar') . ' --format json %t',
\ ale_linters#typescript#tslint#GetCommand(bufnr(''))