From b4c0335ebceb5ba360a71dd3d0f10ec1d5807a83 Mon Sep 17 00:00:00 2001 From: w0rp Date: Mon, 24 Apr 2017 21:38:12 +0100 Subject: [PATCH] Handle Unix errors with no space after the colon --- autoload/ale/handlers.vim | 2 +- test/handler/test_common_handlers.vader | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/autoload/ale/handlers.vim b/autoload/ale/handlers.vim index 011817a..38c9fd4 100644 --- a/autoload/ale/handlers.vim +++ b/autoload/ale/handlers.vim @@ -12,7 +12,7 @@ function! s:HandleUnixFormat(buffer, lines, type) abort " file.go:27: missing argument for Printf("%s"): format reads arg 2, have only 1 args " file.go:53:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) " file.go:5:2: expected declaration, found 'STRING' "log" - let l:pattern = '^' . s:path_pattern . ':\(\d\+\):\?\(\d\+\)\?:\? \(.\+\)$' + let l:pattern = '^' . s:path_pattern . ':\(\d\+\):\?\(\d\+\)\?:\? \?\(.\+\)$' let l:output = [] for l:line in a:lines diff --git a/test/handler/test_common_handlers.vader b/test/handler/test_common_handlers.vader index b5e0c2d..13bae8c 100644 --- a/test/handler/test_common_handlers.vader +++ b/test/handler/test_common_handlers.vader @@ -89,6 +89,27 @@ Execute (HandleUnixFormatAsError should handle some example lines of output): \ 'test.pug:1:1 ".b" is not a valid class name. Class names must begin with "-", "_" or a letter and can only contain "_", "-", a-z and 0-9.', \ ]) +Execute (HandleUnixFormatAsError should handle lines with no space after the colon): + AssertEqual + \ [ + \ { + \ 'lnum': 27, + \ 'col': 0, + \ 'type': 'E', + \ 'text': 'foo', + \ }, + \ { + \ 'lnum': 53, + \ 'col': 10, + \ 'type': 'E', + \ 'text': 'bar', + \ }, + \ ], + \ ale#handlers#HandleUnixFormatAsError(42, [ + \ 'some_file.xyz:27:foo', + \ 'some_file.xyz:53:10:bar', + \ ]) + Execute (HandleUnixFormatAsWarning should handle some example lines of output): AssertEqual \ [