hasufell
/
ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

handle column number in javac linter (#660) 

* handle column number in javac linter

* Updated tests with column number for javac errors.

* Updated tests with column number for javac errors.
This commit is contained in:
oaue 2017-06-19 12:45:09 +02:00 committed by w0rp
parent 66b9d025bb
commit b44bd4e24f
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ale_linters/java/javac.vim
View File

@ -59,11 +59,14 @@ function! ale_linters#java#javac#Handle(buffer, lines) abort
" Main.java:16: error: ';' expected " Main.java:16: error: ';' expected
let l:pattern = '\v^.*:(\d+): (.+):(.+)$' let l:pattern = '\v^.*:(\d+): (.+):(.+)$'
let l:col_pattern = '\v^(\s*\^)$'
let l:symbol_pattern = '\v^ +symbol: *(class|method) +([^ ]+)' let l:symbol_pattern = '\v^ +symbol: *(class|method) +([^ ]+)'
let l:output = [] let l:output = []
for l:match in ale#util#GetMatches(a:lines, [l:pattern, l:symbol_pattern]) for l:match in ale#util#GetMatches(a:lines, [l:pattern, l:col_pattern, l:symbol_pattern])
if empty(l:match[3]) if empty(l:match[2]) && empty(l:match[3])
let l:output[-1].col = len(l:match[1])
elseif empty(l:match[3])
" Add symbols to 'cannot find symbol' errors. " Add symbols to 'cannot find symbol' errors.
if l:output[-1].text ==# 'error: cannot find symbol' if l:output[-1].text ==# 'error: cannot find symbol'
let l:output[-1].text .= ': ' . l:match[2] let l:output[-1].text .= ': ' . l:match[2]

3
test/handler/test_javac_handler.vader
View File

@ -14,11 +14,13 @@ Execute(The javac handler should handle cannot find symbol errors):
\ }, \ },
\ { \ {
\ 'lnum': 2, \ 'lnum': 2,
\ 'col': 5,
\ 'text': 'error: cannot find symbol: BadName', \ 'text': 'error: cannot find symbol: BadName',
\ 'type': 'E', \ 'type': 'E',
\ }, \ },
\ { \ {
\ 'lnum': 34, \ 'lnum': 34,
\ 'col': 5,
\ 'text': 'error: cannot find symbol: BadName2', \ 'text': 'error: cannot find symbol: BadName2',
\ 'type': 'E', \ 'type': 'E',
\ }, \ },
@ -29,6 +31,7 @@ Execute(The javac handler should handle cannot find symbol errors):
\ }, \ },
\ { \ {
\ 'lnum': 42, \ 'lnum': 42,
\ 'col': 11,
\ 'text': 'error: cannot find symbol: bar()', \ 'text': 'error: cannot find symbol: bar()',
\ 'type': 'E', \ 'type': 'E',
\ }, \ },