From a0aa9aa9b721a73e81dd0091f37826d5e8a336d2 Mon Sep 17 00:00:00 2001 From: w0rp Date: Thu, 12 Apr 2018 21:01:35 +0100 Subject: [PATCH] Fix #1495 - Fall back to /bin/sh when shell=pwsh --- autoload/ale/job.vim | 2 +- test/test_prepare_command.vader | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/autoload/ale/job.vim b/autoload/ale/job.vim index 2711e99..33040bb 100644 --- a/autoload/ale/job.vim +++ b/autoload/ale/job.vim @@ -208,7 +208,7 @@ function! ale#job#PrepareCommand(buffer, command) abort return 'cmd /s/c "' . l:command . '"' endif - if &shell =~? 'fish$' + if &shell =~? 'fish$\|pwsh$' return ['/bin/sh', '-c', l:command] endif diff --git a/test/test_prepare_command.vader b/test/test_prepare_command.vader index ed9272a..75e4c0c 100644 --- a/test/test_prepare_command.vader +++ b/test/test_prepare_command.vader @@ -22,6 +22,23 @@ Execute(sh should be used when the shell is fish): AssertEqual ['/bin/sh', '-c', 'foobar'], ale#job#PrepareCommand(bufnr(''), 'foobar') endif +Execute(sh should be used when the shell is powershell): + if !has('win32') + " Set something else, so we will replace that too. + let &shellcmdflag = '-f' + let &shell = 'pwsh' + + AssertEqual ['/bin/sh', '-c', 'foobar'], ale#job#PrepareCommand(bufnr(''), 'foobar') + + let &shell = '/usr/bin/pwsh' + + AssertEqual ['/bin/sh', '-c', 'foobar'], ale#job#PrepareCommand(bufnr(''), 'foobar') + + let &shell = '/usr/local/bin/pwsh' + + AssertEqual ['/bin/sh', '-c', 'foobar'], ale#job#PrepareCommand(bufnr(''), 'foobar') + endif + Execute(Other shells should be used when set): if !has('win32') let &shell = '/bin/bash'