Use the same formatting as other files for the dogma linter file, and cover the Handler function with tests

This commit is contained in:
w0rp 2017-03-27 12:56:54 +01:00
parent ba97017380
commit 82fde0ea51
2 changed files with 61 additions and 32 deletions

View File

@ -37,8 +37,9 @@ function! ale_linters#elixir#dogma#Handle(buffer, lines) abort
endfunction
call ale#linter#Define('elixir', {
\ 'name': 'dogma',
\ 'executable': 'mix',
\ 'command': 'mix dogma %s --format=flycheck',
\ 'lint_file': 1,
\ 'callback': 'ale_linters#elixir#dogma#Handle' })
\ 'name': 'dogma',
\ 'executable': 'mix',
\ 'command': 'mix dogma %s --format=flycheck',
\ 'lint_file': 1,
\ 'callback': 'ale_linters#elixir#dogma#Handle',
\})

View File

@ -0,0 +1,28 @@
Execute(The dogma handler should parse lines correctly):
runtime ale_linters/elixir/dogma.vim
AssertEqual
\ [
\ {
\ 'bufnr': 347,
\ 'lnum': 18,
\ 'col': 5,
\ 'text': 'Some error',
\ 'type': 'E',
\ },
\ {
\ 'bufnr': 347,
\ 'lnum': 19,
\ 'col': 7,
\ 'text': 'Some warning',
\ 'type': 'W',
\ },
\ ],
\ ale_linters#elixir#dogma#Handle(347, [
\ 'This line should be ignored completely',
\ 'lib/filename.ex:18:5: C: Some error',
\ 'lib/filename.ex:19:7: R: Some warning',
\ ])
After:
call ale#linter#Reset()