hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove some redundant eslint test code

Browse Source
This commit is contained in:
w0rp 2017-08-22 21:40:00 +01:00
parent 2f19cf874b
commit 80c7fbcefe
3 changed files with 28 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/eslint-test-files/eslintignore/ignored.js
View File

@ -1 +0,0 @@
var foo = "bar";

28
test/handler/test_eslint_handler.vader
View File

@ -1,4 +1,11 @@
Before:
Save g:ale_javascript_eslint_suppress_eslintignore
let g:ale_javascript_eslint_suppress_eslintignore = 0
After:
Restore
unlet! g:config_error_lines
Execute(The eslint handler should parse lines correctly):
@ -206,3 +213,24 @@ Execute(The eslint hint about using typescript-eslint-parser):
\ ale#handlers#eslint#Handle(bufnr(''), [
\ 'foo.ts:451:2: Parsing error: Unexpected token ) [Error]',
\ ])
Execute(eslint should warn about ignored files by default):
AssertEqual
\ [{
\ 'lnum': 0,
\ 'col': 0,
\ 'type': 'W',
\ 'text': 'File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]'
\ }],
\ ale#handlers#eslint#Handle(347, [
\ '/path/to/some/ignored.js:0:0: File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]',
\ ])
Execute(eslint should not warn about ignored files when explicitly disabled):
let g:ale_javascript_eslint_suppress_eslintignore = 1
AssertEqual
\ [],
\ ale#handlers#eslint#Handle(347, [
\ '/path/to/some/ignored.js:0:0: File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]',
\ ])

38
test/test_eslint_suppress_eslintignore.vader
View File

@ -1,38 +0,0 @@
Before:
Save g:ale_javascript_eslint_suppress_eslintignore
call ale#test#SetDirectory('/testplugin/test')
runtime ale_linters/javascript/eslint.vim
After:
Restore
call ale#test#RestoreDirectory()
call ale#linter#Reset()
Execute(eslint should warn about ignored file):
call ale#test#SetFilename('eslint-test-files/eslintignore/ignore.js')
AssertEqual
\ [{
\ 'lnum': 0,
\ 'col': 0,
\ 'type': 'W',
\ 'text': 'File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]'
\ }],
\ ale#handlers#eslint#Handle(347, [
\ '/path/to/some/ignored.js:0:0: File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]',
\ ])
Execute(eslint should not warn about ignored file when configured):
let g:ale_javascript_eslint_suppress_eslintignore = 1
call ale#test#SetFilename('eslint-test-files/eslintignore/ignore.js')
AssertEqual
\ [],
\ ale#handlers#eslint#Handle(347, [
\ '/path/to/some/ignored.js:0:0: File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]',
\ ])