hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix #398 - Report problems with the eslint configuration file

Browse Source
This commit is contained in:
w0rp 2017-04-20 13:07:32 +01:00
parent 0384cabd77
commit 7fd7630153
2 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ale_linters/javascript/eslint.vim
View File

@ -42,6 +42,7 @@ endfunction
function! ale_linters#javascript#eslint#Handle(buffer, lines) abort function! ale_linters#javascript#eslint#Handle(buffer, lines) abort
let l:config_error_pattern = '\v^ESLint couldn''t find a configuration file' let l:config_error_pattern = '\v^ESLint couldn''t find a configuration file'
\ . '|^Cannot read config file' \ . '|^Cannot read config file'
\ . '|^.*Configuration for rule .* is invalid'
" Look for a message in the first few lines which indicates that " Look for a message in the first few lines which indicates that
" a configuration file couldn't be found. " a configuration file couldn't be found.

30
test/handler/test_eslint_handler.vader
View File

@ -87,3 +87,33 @@ Execute(The eslint handler should print a message for config parsing errors):
After: After:
unlet! g:config_error_lines unlet! g:config_error_lines
call ale#linter#Reset() call ale#linter#Reset()
Execute(The eslint handler should print a message for invalid configuration settings):
let g:config_error_lines = [
\ '/home/w0rp/git/wazoku/wazoku-spotlight/.eslintrc.js:',
\ ' Configuration for rule "indent" is invalid:',
\ ' Value "off" is the wrong type.',
\ '',
\ 'Error: /home/w0rp/git/wazoku/wazoku-spotlight/.eslintrc.js:',
\ ' Configuration for rule "indent" is invalid:',
\ ' Value "off" is the wrong type.',
\ '',
\ ' at validateRuleOptions (/usr/local/lib/node_modules/eslint/lib/config/config-validator.js:115:15)',
\ ' at /usr/local/lib/node_modules/eslint/lib/config/config-validator.js:162:13',
\ ' at Array.forEach (native)',
\ ' at Object.validate (/usr/local/lib/node_modules/eslint/lib/config/config-validator.js:161:35)',
\ ' at Object.load (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:522:19)',
\ ' at loadConfig (/usr/local/lib/node_modules/eslint/lib/config.js:63:33)',
\ ' at getLocalConfig (/usr/local/lib/node_modules/eslint/lib/config.js:130:29)',
\ ' at Config.getConfig (/usr/local/lib/node_modules/eslint/lib/config.js:256:22)',
\ ' at processText (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:224:33)',
\ ' at CLIEngine.executeOnText (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:756:26)',
\]
AssertEqual
\ [{
\ 'lnum': 1,
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
\ 'detail': join(g:config_error_lines, "\n"),
\ }],
\ ale_linters#javascript#eslint#Handle(347, g:config_error_lines[:])