From 7edcb2210b2b60d5eaf81381e5d9443369576c28 Mon Sep 17 00:00:00 2001
From: w0rp <devw0rp@gmail.com>
Date: Sun, 12 Nov 2017 11:35:01 +0000
Subject: [PATCH] Show problems from other files for lessc

---
 ale_linters/less/lessc.vim            | 11 ++++-
 test/handler/test_lessc_handler.vader | 69 +++++++++++++++++++++++++++
 2 files changed, 78 insertions(+), 2 deletions(-)
 create mode 100644 test/handler/test_lessc_handler.vader

diff --git a/ale_linters/less/lessc.vim b/ale_linters/less/lessc.vim
index 8b7985a..108679d 100755
--- a/ale_linters/less/lessc.vim
+++ b/ale_linters/less/lessc.vim
@@ -24,17 +24,24 @@ function! ale_linters#less#lessc#GetCommand(buffer) abort
 endfunction
 
 function! ale_linters#less#lessc#Handle(buffer, lines) abort
+    let l:dir = expand('#' . a:buffer . ':p:h')
     " Matches patterns like the following:
     let l:pattern = '^\(\w\+\): \(.\{-}\) in \(.\{-}\) on line \(\d\+\), column \(\d\+\):$'
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        call add(l:output, {
+        let l:item = {
         \   'lnum': l:match[4] + 0,
         \   'col': l:match[5] + 0,
         \   'text': l:match[2],
         \   'type': 'E',
-        \})
+        \}
+
+        if l:match[3] isnot# '-'
+            let l:item.filename = ale#path#GetAbsPath(l:dir, l:match[3])
+        endif
+
+        call add(l:output, l:item)
     endfor
 
     return l:output
diff --git a/test/handler/test_lessc_handler.vader b/test/handler/test_lessc_handler.vader
new file mode 100644
index 0000000..530c582
--- /dev/null
+++ b/test/handler/test_lessc_handler.vader
@@ -0,0 +1,69 @@
+Before:
+  call ale#test#SetDirectory('/testplugin/test/handler')
+  call ale#test#SetFilename('testfile.less')
+
+  runtime ale_linters/less/lessc.vim
+
+After:
+  call ale#test#RestoreDirectory()
+  call ale#linter#Reset()
+
+Execute(The lessc handler should handle errors for the current file correctly):
+  AssertEqual
+  \ [
+  \   {
+  \     'lnum': 2,
+  \     'col': 1,
+  \     'type': 'E',
+  \     'text': 'Unrecognised input. Possibly missing something',
+  \   },
+  \ ],
+  \ ale_linters#less#lessc#Handle(bufnr(''), [
+  \   'ParseError: Unrecognised input. Possibly missing something in - on line 2, column 1:',
+  \   '1 vwewww',
+  \   '2    ',
+  \])
+
+Execute(The lessc handler should handle errors for other files in the same directory correctly):
+  AssertEqual
+  \ [
+  \   {
+  \     'lnum': 2,
+  \     'col': 1,
+  \     'type': 'E',
+  \     'text': 'Unrecognised input. Possibly missing something',
+  \     'filename': ale#path#Winify(g:dir . '/imported.less')
+  \   },
+  \   {
+  \     'lnum': 2,
+  \     'col': 1,
+  \     'type': 'E',
+  \     'text': 'Unrecognised input. Possibly missing something',
+  \     'filename': ale#path#Winify(g:dir . '/imported.less')
+  \   },
+  \ ],
+  \ ale_linters#less#lessc#Handle(bufnr(''), [
+  \   'ParseError: Unrecognised input. Possibly missing something in imported.less on line 2, column 1:',
+  \   '1 vwewww',
+  \   '2    ',
+  \   'ParseError: Unrecognised input. Possibly missing something in ./imported.less on line 2, column 1:',
+  \   '1 vwewww',
+  \   '2    ',
+  \])
+
+Execute(The lessc handler should handle errors for files in directories above correctly):
+  AssertEqual
+  \ [
+  \   {
+  \     'lnum': 2,
+  \     'col': 1,
+  \     'type': 'E',
+  \     'text': 'Unrecognised input. Possibly missing something',
+  \     'filename': ale#path#Winify(g:dir . '/../imported2.less')
+  \   },
+  \ ],
+  \ ale_linters#less#lessc#Handle(bufnr(''), [
+  \   'ParseError: Unrecognised input. Possibly missing something in ../imported2.less on line 2, column 1:',
+  \   '1 vwewww',
+  \   '2    ',
+  \])