hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update the issue template to tell you where to find command callback tests

Browse Source
This commit is contained in:
w0rp 2018-05-15 13:14:20 +01:00
parent 38c66d33fe
commit 4a76cb0dd5
No known key found for this signature in database
GPG Key ID: 0FC1ECAA8C81CD83
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
PULL_REQUEST_TEMPLATE.md
View File

@ -12,7 +12,8 @@ READ THIS: Before creating a pull request, please consider the following first.
that ALE can work with, please add Vader tests for them. Look at existing that ALE can work with, please add Vader tests for them. Look at existing
tests in the test/handler directory, etc. tests in the test/handler directory, etc.
* If you add or modify a function for computing a command line string for * If you add or modify a function for computing a command line string for
running a command, please add Vader tests for that. running a command, please add Vader tests for that. Look at existing
tests in the test/command_callback directory, etc.
* Generally try and cover anything with Vader tests, although some things just * Generally try and cover anything with Vader tests, although some things just
can't be tested with Vader, or at least they can be hard to test. Consider can't be tested with Vader, or at least they can be hard to test. Consider
breaking up your code so that some parts can be tested, and generally open up breaking up your code so that some parts can be tested, and generally open up