#318 Do not capitalize the first character for cursor messages

This commit is contained in:
w0rp 2017-05-21 19:51:34 +01:00
parent 23ee0d0992
commit 3a289dab6b
2 changed files with 19 additions and 4 deletions

View File

@ -7,15 +7,13 @@ function! s:GetMessage(linter, type, text) abort
let l:type = a:type ==# 'E' let l:type = a:type ==# 'E'
\ ? g:ale_echo_msg_error_str \ ? g:ale_echo_msg_error_str
\ : g:ale_echo_msg_warning_str \ : g:ale_echo_msg_warning_str
" Capitalize the 1st character
let l:text = toupper(a:text[0]) . a:text[1:-1]
" Replace handlers if they exist " Replace handlers if they exist
for [l:k, l:v] in items({'linter': a:linter, 'severity': l:type}) for [l:k, l:v] in items({'linter': a:linter, 'severity': l:type})
let l:msg = substitute(l:msg, '\V%' . l:k . '%', l:v, '') let l:msg = substitute(l:msg, '\V%' . l:k . '%', l:v, '')
endfor endfor
return printf(l:msg, l:text) return printf(l:msg, a:text)
endfunction endfunction
function! s:EchoWithShortMess(setting, message) abort function! s:EchoWithShortMess(setting, message) abort

View File

@ -32,7 +32,17 @@ Before:
\ 'nr': -1, \ 'nr': -1,
\ 'type': 'E', \ 'type': 'E',
\ 'text': 'Missing radix parameter (radix)' \ 'text': 'Missing radix parameter (radix)'
\ } \ },
\ {
\ 'lnum': 3,
\ 'col': 1,
\ 'bufnr': bufnr('%'),
\ 'vcol': 0,
\ 'linter_name': 'eslint',
\ 'nr': -1,
\ 'type': 'E',
\ 'text': 'lowercase error'
\ },
\ ], \ ],
\ }, \ },
\} \}
@ -73,6 +83,7 @@ After:
Given javascript(A Javscript file with warnings/errors): Given javascript(A Javscript file with warnings/errors):
var x = 3 var x = 3
var x = 5*2 + parseInt("10"); var x = 5*2 + parseInt("10");
// comment
Execute(Messages should be shown for the correct lines): Execute(Messages should be shown for the correct lines):
call cursor(1, 1) call cursor(1, 1)
@ -124,3 +135,9 @@ Execute(ALEDetail should print regular 'text' attributes):
redir END redir END
AssertEqual "\nInfix operators must be spaced. (space-infix-ops)", g:output AssertEqual "\nInfix operators must be spaced. (space-infix-ops)", g:output
Execute(ALEDetail should not capitlise cursor messages):
call cursor(3, 1)
call ale#cursor#EchoCursorWarning()
AssertEqual 'lowercase error', GetLastMessage()