Revert "Don't save the sign ID on loclist items. This approach won't work."

This reverts commit f25a543260.

autoload/ale/sign.vim

@@ -118,12 +118,20 @@ function! ale#sign#SetSigns(buffer, loclist) abort
 
     " Add the new signs,
     for l:index in range(0, len(l:signlist) - 1)
+        let l:sign_id = l:index + g:ale_sign_offset + 1
         let l:sublist = l:signlist[l:index]
         let l:type = !empty(filter(copy(l:sublist), 'v:val.type ==# ''E'''))
         \   ? 'ALEErrorSign'
         \   : 'ALEWarningSign'
 
-        let l:sign_line = 'sign place ' . (l:index + g:ale_sign_offset + 1)
+        " Save the sign IDs we are setting back on our loclist objects.
+        " These IDs can be used later for changing line numbers of items
+        " we keep, based on what Vim adjusts automatically.
+        for l:obj in l:sublist
+            let l:obj.sign_id = l:sign_id
+        endfor
+
+        let l:sign_line = 'sign place ' . l:sign_id
             \. ' line=' . l:sublist[0].lnum
             \. ' name=' . l:type
             \. ' buffer=' . a:buffer

test/test_linting_updates_loclist.vader

@@ -13,6 +13,7 @@ Before:
   \   'type': 'W',
   \   'col': 10,
   \   'text': 'Infix operators must be spaced. [Warning/space-infix-ops]',
+  \   'sign_id': 1000001,
   \ },
   \ {
   \   'lnum': 2,
@@ -23,6 +24,7 @@ Before:
   \   'type': 'E',
   \   'col': 10,
   \   'text': 'Missing semicolon. [Error/semi]',
+  \   'sign_id': 1000002,
   \ }
   \]