From 4d44996af618bf3907370e45a1e875e3802398d0 Mon Sep 17 00:00:00 2001
From: Eddie Lebow <elebow@users.github.com>
Date: Sat, 11 Nov 2017 15:15:19 -0500
Subject: [PATCH] perlcritic: all issues are warnings

Perlcritic is a style checker, not a syntax validator.

This change was originally proposed by @RsrchBoy in
https://github.com/w0rp/ale/pull/784.
---
 ale_linters/perl/perlcritic.vim            |  1 +
 test/handler/test_perlcritic_handler.vader | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+)
 create mode 100644 test/handler/test_perlcritic_handler.vader

diff --git a/ale_linters/perl/perlcritic.vim b/ale_linters/perl/perlcritic.vim
index df2f8b2..24f7eb8 100644
--- a/ale_linters/perl/perlcritic.vim
+++ b/ale_linters/perl/perlcritic.vim
@@ -61,6 +61,7 @@ function! ale_linters#perl#perlcritic#Handle(buffer, lines) abort
         \   'lnum': l:match[1],
         \   'col': l:match[2],
         \   'text': l:match[3],
+        \   'type': 'W'
         \})
     endfor
 
diff --git a/test/handler/test_perlcritic_handler.vader b/test/handler/test_perlcritic_handler.vader
new file mode 100644
index 0000000..f00b07d
--- /dev/null
+++ b/test/handler/test_perlcritic_handler.vader
@@ -0,0 +1,20 @@
+Before:
+  runtime ale_linters/perl/perlcritic.vim
+
+After:
+  call ale#linter#Reset()
+
+Execute(The Perl::Critic handler should create all issues as warnings):
+  AssertEqual
+  \  [
+  \    {
+  \      'lnum': '21',
+  \      'col': '17',
+  \      'text': 'Regular expression without "/m" flag',
+  \      'type': 'W',
+  \    }
+  \  ],
+  \  ale_linters#perl#perlcritic#Handle(99, [
+  \      '21:17 Regular expression without "/m" flag'
+  \  ])
+