Escape the perl executable, and cover the callbacks with tests
This commit is contained in:
parent
a4f8506227
commit
2f9869de44
@ -12,7 +12,7 @@ function! ale_linters#perl#perl#GetExecutable(buffer) abort
|
|||||||
endfunction
|
endfunction
|
||||||
|
|
||||||
function! ale_linters#perl#perl#GetCommand(buffer) abort
|
function! ale_linters#perl#perl#GetCommand(buffer) abort
|
||||||
return ale_linters#perl#perl#GetExecutable(a:buffer)
|
return ale#Escape(ale_linters#perl#perl#GetExecutable(a:buffer))
|
||||||
\ . ' ' . ale#Var(a:buffer, 'perl_perl_options')
|
\ . ' ' . ale#Var(a:buffer, 'perl_perl_options')
|
||||||
\ . ' %t'
|
\ . ' %t'
|
||||||
endfunction
|
endfunction
|
||||||
|
37
test/command_callback/test_perl_command_callback.vader
Normal file
37
test/command_callback/test_perl_command_callback.vader
Normal file
@ -0,0 +1,37 @@
|
|||||||
|
Before:
|
||||||
|
Save g:ale_perl_perl_executable
|
||||||
|
Save g:ale_perl_perl_options
|
||||||
|
|
||||||
|
unlet! g:ale_perl_perl_executable
|
||||||
|
unlet! g:ale_perl_perl_options
|
||||||
|
|
||||||
|
runtime ale_linters/perl/perl.vim
|
||||||
|
|
||||||
|
After:
|
||||||
|
Restore
|
||||||
|
|
||||||
|
unlet! b:ale_perl_perl_executable
|
||||||
|
unlet! b:ale_perl_perl_options
|
||||||
|
|
||||||
|
call ale#linter#Reset()
|
||||||
|
|
||||||
|
Execute(The default Perl command callback should be correct):
|
||||||
|
AssertEqual
|
||||||
|
\ 'perl',
|
||||||
|
\ ale_linters#perl#perl#GetExecutable(bufnr(''))
|
||||||
|
|
||||||
|
AssertEqual
|
||||||
|
\ ale#Escape('perl') . ' -c -Mwarnings -Ilib %t',
|
||||||
|
\ ale_linters#perl#perl#GetCommand(bufnr(''))
|
||||||
|
|
||||||
|
Execute(Overriding the executable and command should work):
|
||||||
|
let b:ale_perl_perl_executable = 'foobar'
|
||||||
|
let b:ale_perl_perl_options = '-w'
|
||||||
|
|
||||||
|
AssertEqual
|
||||||
|
\ 'foobar',
|
||||||
|
\ ale_linters#perl#perl#GetExecutable(bufnr(''))
|
||||||
|
|
||||||
|
AssertEqual
|
||||||
|
\ ale#Escape('foobar') . ' -w %t',
|
||||||
|
\ ale_linters#perl#perl#GetCommand(bufnr(''))
|
Loading…
Reference in New Issue
Block a user