From 425482116ed4f8baa9e568be50968f412bd5ca0f Mon Sep 17 00:00:00 2001 From: Aliou Diallo Date: Tue, 14 Nov 2017 17:50:15 +0100 Subject: [PATCH] #852 - Capture error codes for Rubocop --- ale_linters/ruby/rubocop.vim | 3 ++- test/handler/test_rubocop_handler.vader | 12 ++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/ale_linters/ruby/rubocop.vim b/ale_linters/ruby/rubocop.vim index 2a4388f..777f457 100644 --- a/ale_linters/ruby/rubocop.vim +++ b/ale_linters/ruby/rubocop.vim @@ -34,7 +34,8 @@ function! ale_linters#ruby#rubocop#Handle(buffer, lines) abort \ 'lnum': l:error['location']['line'] + 0, \ 'col': l:start_col, \ 'end_col': l:start_col + l:error['location']['length'] - 1, - \ 'text': printf('%s [%s]', l:error['message'], l:error['cop_name']), + \ 'code': l:error['cop_name'], + \ 'text': l:error['message'], \ 'type': ale_linters#ruby#rubocop#GetType(l:error['severity']), \}) endfor diff --git a/test/handler/test_rubocop_handler.vader b/test/handler/test_rubocop_handler.vader index 4d3bbe2..ef0137d 100644 --- a/test/handler/test_rubocop_handler.vader +++ b/test/handler/test_rubocop_handler.vader @@ -12,28 +12,32 @@ Execute(The rubocop handler should parse lines correctly): \ 'lnum': 83, \ 'col': 29, \ 'end_col': 35, - \ 'text': 'Prefer single-quoted strings... [Style/SomeCop]', + \ 'text': 'Prefer single-quoted strings...', + \ 'code': 'Style/SomeCop', \ 'type': 'W', \ }, \ { \ 'lnum': 12, \ 'col': 2, \ 'end_col': 2, - \ 'text': 'Some error [Style/SomeOtherCop]', + \ 'text': 'Some error', + \ 'code': 'Style/SomeOtherCop', \ 'type': 'E', \ }, \ { \ 'lnum': 10, \ 'col': 5, \ 'end_col': 12, - \ 'text': 'Regular warning [Style/WarningCop]', + \ 'text': 'Regular warning', + \ 'code': 'Style/WarningCop', \ 'type': 'W', \ }, \ { \ 'lnum': 11, \ 'col': 1, \ 'end_col': 1, - \ 'text': 'Another error [Style/SpaceBeforeBlockBraces]', + \ 'text': 'Another error', + \ 'code': 'Style/SpaceBeforeBlockBraces', \ 'type': 'E', \ }, \ ],