hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Puppet: allow for when parser doesn't supply column for errors (#1182)

Browse Source 
* puppet: add test for puppet parser validate

* puppet: handle where parser validate doesn't supply the column

* puppet: add test for when parser validate doesn't supply column

* Fix puppet regex to handle Windows paths
This commit is contained in:
Dave Wongillies 2017-12-02 04:29:17 -08:00 committed by w0rp
parent f5fc746d00
commit 2bd966c5cc
2 changed files with 47 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ale_linters/puppet/puppet.vim
View File

@ -3,8 +3,9 @@
function! ale_linters#puppet#puppet#Handle(buffer, lines) abort
" Matches patterns like the following:
" Error: Could not parse for environment production: Syntax error at ':' at /root/puppetcode/modules/nginx/manifests/init.pp:43:12
" Error: Could not parse for environment production: Syntax error at '='; expected '}' at /root/puppetcode/modules/pancakes/manifests/init.pp:5"
let l:pattern = '^Error: .*: \(.\+\) at .\+:\(\d\+\):\(\d\+\)$'
let l:pattern = '^Error: .*: \(.\+\) at .\+\.pp:\(\d\+\):\=\(\d*\)'
let l:output = []
for l:match in ale#util#GetMatches(a:lines, l:pattern)

45
test/handler/test_puppet_handler.vader Normal file
View File

@ -0,0 +1,45 @@
Before:
runtime ale_linters/puppet/puppet.vim
After:
call ale#linter#Reset()
Execute(The puppet handler should parse lines correctly when no column is supplied):
" Line Error
AssertEqual
\ [
\ {
\ 'lnum': 5,
\ 'col': 0,
\ 'text': "Syntax error at '='; expected '}'"
\ },
\ {
\ 'lnum': 3,
\ 'col': 0,
\ 'text': "Syntax error at '='; expected '}'"
\ },
\ ],
\ ale_linters#puppet#puppet#Handle(255, [
\ "Error: Could not parse for environment production: Syntax error at '='; expected '}' at /root/puppetcode/modules/pancakes/manifests/init.pp:5",
\ "Error: Could not parse for environment production: Syntax error at '='; expected '}' at C:/puppet/modules/pancakes/manifests/init.pp:3",
\ ])
Execute(The puppet handler should parse lines and column correctly):
" Line Error
AssertEqual
\ [
\ {
\ 'lnum': 43,
\ 'col': 12,
\ 'text': "Syntax error at ':'"
\ },
\ {
\ 'lnum': 54,
\ 'col': 9,
\ 'text': "Syntax error at ':'"
\ }
\ ],
\ ale_linters#puppet#puppet#Handle(255, [
\ "Error: Could not parse for environment production: Syntax error at ':' at /root/puppetcode/modules/nginx/manifests/init.pp:43:12",
\ "Error: Could not parse for environment production: Syntax error at ':' at C:/puppet/modules/nginx/manifests/init.pp:54:9",
\ ])