hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

#710 - Show warnings as warnings for ghc

Browse Source
This commit is contained in:
w0rp 2017-07-07 00:28:22 +01:00
parent 8315c0e337
commit 130928590b
2 changed files with 27 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
autoload/ale/handlers/haskell.vim
View File

@ -35,17 +35,21 @@ function! ale#handlers#haskell#HandleGHCFormat(buffer, lines) abort
continue
endif
let l:errors = matchlist(l:match[4], '\(warning:\|error:\)\(.*\)')
let l:errors = matchlist(l:match[4], '\v([wW]arning|[eE]rror): ?(.*)')
if len(l:errors) > 0
let l:type = l:errors[1]
let l:ghc_type = l:errors[1]
let l:text = l:errors[2]
else
let l:type = ''
let l:text = l:match[4]
let l:ghc_type = ''
let l:text = l:match[4][:0] ==# ' ' ? l:match[4][1:] : l:match
endif
let l:type = l:type ==# '' ? 'E' : toupper(l:type[0])
if l:ghc_type ==? 'Warning'
let l:type = 'W'
else
let l:type = 'E'
endif
call add(l:output, {
\ 'lnum': l:match[2] + 0,

21
test/handler/test_ghc_handler.vader
View File

@ -25,13 +25,13 @@ Execute(The ghc handler should handle ghc 8 output):
\ 'lnum': 6,
\ 'type': 'E',
\ 'col': 1,
\ 'text': ' Failed to load interface for ‘GitHub.Data’ Use -v to see a list of the files searched for.',
\ 'text': 'Failed to load interface for ‘GitHub.Data’ Use -v to see a list of the files searched for.',
\ },
\ {
\ 'lnum': 7,
\ 'type': 'W',
\ 'col': 1,
\ 'text': ' Failed to load interface for ‘GitHub.Endpoints.PullRequests’ Use -v to see a list of the files searched for.',
\ 'text': 'Failed to load interface for ‘GitHub.Endpoints.PullRequests’ Use -v to see a list of the files searched for.',
\ },
\ ],
\ ale#handlers#haskell#HandleGHCFormat(bufnr(''), [
@ -54,10 +54,25 @@ Execute(The ghc handler should handle ghc 7 output):
\ 'lnum': 168,
\ 'type': 'E',
\ 'col': 1,
\ 'text': ' parse error (possibly incorrect indentation or mismatched brackets)',
\ 'text': 'parse error (possibly incorrect indentation or mismatched brackets)',
\ },
\ {
\ 'lnum': 84,
\ 'col': 1,
\ 'type': 'W',
\ 'text': 'Top-level binding with no type signature:^@ myLayout :: Choose Tall (Choose (Mirror Tall) Full) a',
\ },
\ {
\ 'lnum': 94,
\ 'col': 5,
\ 'type': 'E',
\ 'text': 'Some other error',
\ },
\ ],
\ ale#handlers#haskell#HandleGHCFormat(bufnr(''), [
\ 'src/Main.hs:168:1:',
\ ' parse error (possibly incorrect indentation or mismatched brackets)',
\ 'src/Main.hs:84:1:Warning: Top-level binding with no type signature:^@ myLayout :: Choose Tall (Choose (Mirror Tall) Full) a',
\ 'src/Main.hs:94:5:Error:',
\ ' Some other error',
\ ])