hasufell/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add end columns on php linter #538

Browse Source
This commit is contained in:
Adriaan Zonnenberg 2017-05-17 21:28:29 +02:00
parent 6299da7bd3
commit 05970e1b28
2 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ale_linters/php/php.vim
View File

@ -4,17 +4,23 @@
function! ale_linters#php#php#Handle(buffer, lines) abort
" Matches patterns like the following:
"
" PHP Parse error: syntax error, unexpected ';', expecting ']' in - on line 15
" Parse error: syntax error, unexpected ';', expecting ']' in - on line 15
let l:pattern = '\v^%(Fatal|Parse) error:\s+(.+unexpected ''(.+)%(expecting.+)@<!''.*|.+) in - on line (\d+)'
let l:output = []
for l:match in ale#util#GetMatches(a:lines, l:pattern)
call add(l:output, {
let l:col = empty(l:match[2]) ? 0 : stridx(getline(l:match[3]), l:match[2]) + 1
let l:obj = {
\ 'lnum': l:match[3] + 0,
\ 'col': empty(l:match[2]) ? 0 : stridx(getline(l:match[3]), l:match[2]) + 1,
\ 'col': l:col,
\ 'text': l:match[1],
\})
\}
if l:col != 0
let l:obj.end_col = l:col + strlen(l:match[2]) - 1
endif
call add(l:output, l:obj)
endfor
return l:output

4
test/handler/test_php_handler.vader
View File

@ -14,21 +14,25 @@ Execute(The php handler should calculate column numbers):
\ {
\ 'lnum': 1,
\ 'col': 5,
\ 'end_col': 5,
\ 'text': "syntax error, unexpected ';', expecting ']'",
\ },
\ {
\ 'lnum': 2,
\ 'col': 13,
\ 'end_col': 13,
\ 'text': "syntax error, unexpected '/', expecting function (T_FUNCTION) or const (T_CONST)",
\ },
\ {
\ 'lnum': 3,
\ 'col': 5,
\ 'end_col': 5,
\ 'text': "syntax error, unexpected ')'",
\ },
\ {
\ 'lnum': 4,
\ 'col': 8,
\ 'end_col': 12,
\ 'text': "syntax error, unexpected ''bar'' (T_CONSTANT_ENCAPSED_STRING), expecting ']'",
\ },
\ ],