2016-09-16 08:15:33 +00:00
|
|
|
" Author: ynonp - https://github.com/ynonp
|
2016-10-03 18:55:55 +00:00
|
|
|
" Description: rubocop for Ruby files
|
2016-09-15 20:09:04 +00:00
|
|
|
|
2017-05-18 08:22:34 +00:00
|
|
|
function! ale_linters#ruby#rubocop#GetCommand(buffer) abort
|
2017-07-06 21:47:07 +00:00
|
|
|
let l:executable = ale#handlers#rubocop#GetExecutable(a:buffer)
|
2017-05-18 08:22:34 +00:00
|
|
|
let l:exec_args = l:executable =~? 'bundle$'
|
|
|
|
\ ? ' exec rubocop'
|
|
|
|
\ : ''
|
|
|
|
|
|
|
|
return ale#Escape(l:executable) . l:exec_args
|
|
|
|
\ . ' --format emacs --force-exclusion '
|
|
|
|
\ . ale#Var(a:buffer, 'ruby_rubocop_options')
|
|
|
|
\ . ' --stdin ' . bufname(a:buffer)
|
|
|
|
endfunction
|
|
|
|
|
2017-01-22 14:54:57 +00:00
|
|
|
function! ale_linters#ruby#rubocop#Handle(buffer, lines) abort
|
2016-09-15 07:37:53 +00:00
|
|
|
" Matches patterns line the following:
|
|
|
|
"
|
2017-02-06 06:13:13 +00:00
|
|
|
" <path>:83:29: C: Prefer single-quoted strings when you don't
|
2016-09-15 07:39:26 +00:00
|
|
|
" need string interpolation or special symbols.
|
2017-02-03 21:03:52 +00:00
|
|
|
let l:pattern = '\v:(\d+):(\d+): (.): (.+)'
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:output = []
|
2016-09-15 07:37:53 +00:00
|
|
|
|
2017-04-17 23:35:53 +00:00
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:text = l:match[4]
|
|
|
|
let l:type = l:match[3]
|
2016-09-15 07:37:53 +00:00
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
call add(l:output, {
|
2016-09-15 07:37:53 +00:00
|
|
|
\ 'lnum': l:match[1] + 0,
|
|
|
|
\ 'col': l:match[2] + 0,
|
2016-10-10 23:43:45 +00:00
|
|
|
\ 'text': l:text,
|
2017-02-12 11:15:43 +00:00
|
|
|
\ 'type': index(['F', 'E'], l:type) != -1 ? 'E' : 'W',
|
2016-09-15 07:37:53 +00:00
|
|
|
\})
|
|
|
|
endfor
|
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
return l:output
|
2016-09-15 07:37:53 +00:00
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 18:51:29 +00:00
|
|
|
call ale#linter#Define('ruby', {
|
2016-09-15 20:09:04 +00:00
|
|
|
\ 'name': 'rubocop',
|
2017-07-06 21:47:07 +00:00
|
|
|
\ 'executable_callback': 'ale#handlers#rubocop#GetExecutable',
|
2017-02-03 21:03:52 +00:00
|
|
|
\ 'command_callback': 'ale_linters#ruby#rubocop#GetCommand',
|
2016-09-15 07:37:53 +00:00
|
|
|
\ 'callback': 'ale_linters#ruby#rubocop#Handle',
|
|
|
|
\})
|