2016-10-03 18:55:55 +00:00
|
|
|
" Author: w0rp <devw0rp@gmail.com>
|
|
|
|
" Description: flake8 for python files
|
|
|
|
|
2016-11-14 17:52:31 +00:00
|
|
|
let g:ale_python_flake8_executable =
|
|
|
|
\ get(g:, 'ale_python_flake8_executable', 'flake8')
|
|
|
|
|
2017-04-15 12:35:54 +00:00
|
|
|
" Support an old setting as a fallback.
|
|
|
|
let s:default_options = get(g:, 'ale_python_flake8_args', '')
|
|
|
|
let g:ale_python_flake8_options =
|
|
|
|
\ get(g:, 'ale_python_flake8_options', s:default_options)
|
2017-05-07 15:16:17 +00:00
|
|
|
let g:ale_python_flake8_use_global = get(g:, 'ale_python_flake8_use_global', 0)
|
2016-11-14 17:52:31 +00:00
|
|
|
|
2017-02-06 11:12:21 +00:00
|
|
|
" A map from Python executable paths to semver strings parsed for those
|
|
|
|
" executables, so we don't have to look up the version number constantly.
|
|
|
|
let s:version_cache = {}
|
|
|
|
|
2017-05-07 15:31:33 +00:00
|
|
|
function! s:UsingModule(buffer) abort
|
|
|
|
return ale#Var(a:buffer, 'python_flake8_options') =~# ' *-m flake8'
|
|
|
|
endfunction
|
|
|
|
|
2016-11-14 17:52:31 +00:00
|
|
|
function! ale_linters#python#flake8#GetExecutable(buffer) abort
|
2017-07-05 12:07:55 +00:00
|
|
|
if !s:UsingModule(a:buffer)
|
|
|
|
return ale#python#FindExecutable(a:buffer, 'python_flake8', ['flake8'])
|
2017-05-07 15:16:17 +00:00
|
|
|
endif
|
|
|
|
|
2017-04-16 00:24:08 +00:00
|
|
|
return ale#Var(a:buffer, 'python_flake8_executable')
|
2016-11-14 17:52:31 +00:00
|
|
|
endfunction
|
|
|
|
|
2017-05-07 15:16:17 +00:00
|
|
|
function! ale_linters#python#flake8#ClearVersionCache() abort
|
|
|
|
let s:version_cache = {}
|
|
|
|
endfunction
|
|
|
|
|
2017-02-06 11:12:21 +00:00
|
|
|
function! ale_linters#python#flake8#VersionCheck(buffer) abort
|
|
|
|
let l:executable = ale_linters#python#flake8#GetExecutable(a:buffer)
|
|
|
|
|
|
|
|
" If we have previously stored the version number in a cache, then
|
|
|
|
" don't look it up again.
|
|
|
|
if has_key(s:version_cache, l:executable)
|
|
|
|
" Returning an empty string skips this command.
|
|
|
|
return ''
|
|
|
|
endif
|
|
|
|
|
2017-05-12 08:20:16 +00:00
|
|
|
let l:executable = ale#Escape(ale_linters#python#flake8#GetExecutable(a:buffer))
|
2017-05-07 15:31:33 +00:00
|
|
|
let l:module_string = s:UsingModule(a:buffer) ? ' -m flake8' : ''
|
|
|
|
|
|
|
|
return l:executable . l:module_string . ' --version'
|
2017-02-06 11:12:21 +00:00
|
|
|
endfunction
|
|
|
|
|
|
|
|
" Get the flake8 version from the output, or the cache.
|
|
|
|
function! s:GetVersion(buffer, version_output) abort
|
|
|
|
let l:executable = ale_linters#python#flake8#GetExecutable(a:buffer)
|
|
|
|
let l:version = []
|
|
|
|
|
|
|
|
" Get the version from the cache.
|
|
|
|
if has_key(s:version_cache, l:executable)
|
|
|
|
return s:version_cache[l:executable]
|
|
|
|
endif
|
|
|
|
|
|
|
|
if !empty(a:version_output)
|
|
|
|
" Parse the version string, and store it in the cache.
|
|
|
|
let l:version = ale#semver#Parse(a:version_output[0])
|
|
|
|
let s:version_cache[l:executable] = l:version
|
|
|
|
endif
|
|
|
|
|
|
|
|
return l:version
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
" flake8 versions 3 and up support the --stdin-display-name argument.
|
|
|
|
function! s:SupportsDisplayName(version) abort
|
|
|
|
return !empty(a:version) && ale#semver#GreaterOrEqual(a:version, [3, 0, 0])
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#python#flake8#GetCommand(buffer, version_output) abort
|
|
|
|
let l:version = s:GetVersion(a:buffer, a:version_output)
|
|
|
|
|
|
|
|
" Only include the --stdin-display-name argument if we can parse the
|
|
|
|
" flake8 version, and it is recent enough to support it.
|
|
|
|
let l:display_name_args = s:SupportsDisplayName(l:version)
|
2017-05-07 15:16:17 +00:00
|
|
|
\ ? ' --stdin-display-name %s'
|
2017-02-06 11:12:21 +00:00
|
|
|
\ : ''
|
|
|
|
|
2017-05-07 15:16:17 +00:00
|
|
|
let l:options = ale#Var(a:buffer, 'python_flake8_options')
|
|
|
|
|
2017-05-12 08:20:16 +00:00
|
|
|
return ale#Escape(ale_linters#python#flake8#GetExecutable(a:buffer))
|
2017-05-07 15:16:17 +00:00
|
|
|
\ . (!empty(l:options) ? ' ' . l:options : '')
|
2017-08-10 08:58:32 +00:00
|
|
|
\ . ' --format=default'
|
2017-05-07 15:16:17 +00:00
|
|
|
\ . l:display_name_args . ' -'
|
2016-11-14 17:52:31 +00:00
|
|
|
endfunction
|
|
|
|
|
2017-06-14 15:20:30 +00:00
|
|
|
let s:end_col_pattern_map = {
|
|
|
|
\ 'F405': '\(.\+\) may be undefined',
|
|
|
|
\ 'F821': 'undefined name ''\([^'']\+\)''',
|
|
|
|
\ 'F999': '^''\([^'']\+\)''',
|
|
|
|
\ 'F841': 'local variable ''\([^'']\+\)''',
|
|
|
|
\}
|
|
|
|
|
|
|
|
function! ale_linters#python#flake8#Handle(buffer, lines) abort
|
|
|
|
for l:line in a:lines[:10]
|
|
|
|
if match(l:line, '^Traceback') >= 0
|
|
|
|
return [{
|
|
|
|
\ 'lnum': 1,
|
|
|
|
\ 'text': 'An exception was thrown. See :ALEDetail',
|
|
|
|
\ 'detail': join(a:lines, "\n"),
|
|
|
|
\}]
|
|
|
|
endif
|
|
|
|
endfor
|
|
|
|
|
|
|
|
" Matches patterns line the following:
|
|
|
|
"
|
|
|
|
" Matches patterns line the following:
|
|
|
|
"
|
|
|
|
" stdin:6:6: E111 indentation is not a multiple of four
|
|
|
|
let l:pattern = '\v^[a-zA-Z]?:?[^:]+:(\d+):?(\d+)?: ([[:alnum:]]+) (.*)$'
|
|
|
|
let l:output = []
|
|
|
|
|
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
|
|
|
let l:code = l:match[3]
|
|
|
|
|
2017-08-08 07:39:13 +00:00
|
|
|
if (l:code is# 'W291' || l:code is# 'W293')
|
2017-06-14 15:20:30 +00:00
|
|
|
\ && !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
|
|
|
|
" Skip warnings for trailing whitespace if the option is off.
|
|
|
|
continue
|
|
|
|
endif
|
|
|
|
|
|
|
|
let l:item = {
|
|
|
|
\ 'lnum': l:match[1] + 0,
|
|
|
|
\ 'col': l:match[2] + 0,
|
|
|
|
\ 'text': l:code . ': ' . l:match[4],
|
2017-06-14 15:40:03 +00:00
|
|
|
\ 'type': 'W',
|
2017-06-14 15:20:30 +00:00
|
|
|
\}
|
|
|
|
|
2017-08-08 07:39:13 +00:00
|
|
|
if l:code[:0] is# 'F' || l:code is# 'E999'
|
2017-06-14 15:40:03 +00:00
|
|
|
let l:item.type = 'E'
|
2017-08-08 07:39:13 +00:00
|
|
|
elseif l:code[:0] is# 'E'
|
2017-06-14 15:40:03 +00:00
|
|
|
let l:item.type = 'E'
|
|
|
|
let l:item.sub_type = 'style'
|
2017-08-08 07:39:13 +00:00
|
|
|
elseif l:code[:0] is# 'W'
|
2017-06-14 15:40:03 +00:00
|
|
|
let l:item.sub_type = 'style'
|
|
|
|
endif
|
|
|
|
|
2017-06-14 15:20:30 +00:00
|
|
|
let l:end_col_pattern = get(s:end_col_pattern_map, l:code, '')
|
|
|
|
|
|
|
|
if !empty(l:end_col_pattern)
|
|
|
|
let l:end_col_match = matchlist(l:match[4], l:end_col_pattern)
|
|
|
|
|
|
|
|
if !empty(l:end_col_match)
|
|
|
|
let l:item.end_col = l:item.col + len(l:end_col_match[1]) - 1
|
|
|
|
endif
|
|
|
|
endif
|
|
|
|
|
|
|
|
call add(l:output, l:item)
|
|
|
|
endfor
|
|
|
|
|
|
|
|
return l:output
|
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 18:51:29 +00:00
|
|
|
call ale#linter#Define('python', {
|
2016-09-15 19:20:41 +00:00
|
|
|
\ 'name': 'flake8',
|
2016-11-14 17:52:31 +00:00
|
|
|
\ 'executable_callback': 'ale_linters#python#flake8#GetExecutable',
|
2017-02-06 11:12:21 +00:00
|
|
|
\ 'command_chain': [
|
|
|
|
\ {'callback': 'ale_linters#python#flake8#VersionCheck'},
|
2017-05-31 14:19:58 +00:00
|
|
|
\ {'callback': 'ale_linters#python#flake8#GetCommand', 'output_stream': 'both'},
|
2017-02-06 11:12:21 +00:00
|
|
|
\ ],
|
2017-06-14 15:20:30 +00:00
|
|
|
\ 'callback': 'ale_linters#python#flake8#Handle',
|
2016-09-13 21:23:37 +00:00
|
|
|
\})
|