2016-10-03 12:18:27 +00:00
|
|
|
" Author: w0rp <devw0rp@gmail.com>
|
|
|
|
" Description: This file adds support for using the shellcheck linter with
|
|
|
|
" shell scripts.
|
|
|
|
|
2017-10-02 16:11:54 +00:00
|
|
|
" This global variable can be set with a string of comma-separated error
|
2016-10-03 12:18:27 +00:00
|
|
|
" codes to exclude from shellcheck. For example:
|
|
|
|
"
|
2017-04-29 18:57:34 +00:00
|
|
|
" let g:ale_sh_shellcheck_exclusions = 'SC2002,SC2004'
|
|
|
|
let g:ale_sh_shellcheck_exclusions =
|
|
|
|
\ get(g:, 'ale_sh_shellcheck_exclusions', get(g:, 'ale_linters_sh_shellcheck_exclusions', ''))
|
2016-10-03 12:18:27 +00:00
|
|
|
|
2017-04-09 17:54:25 +00:00
|
|
|
let g:ale_sh_shellcheck_executable =
|
|
|
|
\ get(g:, 'ale_sh_shellcheck_executable', 'shellcheck')
|
|
|
|
|
|
|
|
let g:ale_sh_shellcheck_options =
|
|
|
|
\ get(g:, 'ale_sh_shellcheck_options', '')
|
|
|
|
|
|
|
|
function! ale_linters#sh#shellcheck#GetExecutable(buffer) abort
|
2017-04-16 00:24:08 +00:00
|
|
|
return ale#Var(a:buffer, 'sh_shellcheck_executable')
|
2017-04-09 17:54:25 +00:00
|
|
|
endfunction
|
|
|
|
|
2017-08-28 18:16:23 +00:00
|
|
|
function! ale_linters#sh#shellcheck#GetDialectArgument(buffer) abort
|
|
|
|
let l:shell_type = ale#handlers#sh#GetShellType(a:buffer)
|
|
|
|
|
|
|
|
if !empty(l:shell_type)
|
2017-10-26 20:17:47 +00:00
|
|
|
" Use the dash dialect for /bin/ash, etc.
|
|
|
|
if l:shell_type is# 'ash'
|
|
|
|
return 'dash'
|
|
|
|
endif
|
|
|
|
|
2017-08-28 18:16:23 +00:00
|
|
|
return l:shell_type
|
|
|
|
endif
|
|
|
|
|
|
|
|
" If there's no hashbang, try using Vim's buffer variables.
|
2017-10-26 20:17:47 +00:00
|
|
|
if getbufvar(a:buffer, 'is_bash', 0)
|
2017-08-28 18:16:23 +00:00
|
|
|
return 'bash'
|
2017-10-26 20:17:47 +00:00
|
|
|
elseif getbufvar(a:buffer, 'is_sh', 0)
|
2017-08-28 18:16:23 +00:00
|
|
|
return 'sh'
|
2017-10-26 20:17:47 +00:00
|
|
|
elseif getbufvar(a:buffer, 'is_kornshell', 0)
|
2017-08-28 18:16:23 +00:00
|
|
|
return 'ksh'
|
2016-10-27 08:20:22 +00:00
|
|
|
endif
|
|
|
|
|
|
|
|
return ''
|
|
|
|
endfunction
|
|
|
|
|
2017-11-03 22:08:26 +00:00
|
|
|
function! ale_linters#sh#shellcheck#VersionCheck(buffer) abort
|
|
|
|
let l:executable = ale_linters#sh#shellcheck#GetExecutable(a:buffer)
|
|
|
|
|
|
|
|
" Don't check the version again if we've already cached it.
|
2017-11-09 23:42:54 +00:00
|
|
|
return !ale#semver#HasVersion(l:executable)
|
|
|
|
\ ? ale#Escape(l:executable) . ' --version'
|
|
|
|
\ : ''
|
2017-11-03 22:08:26 +00:00
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#sh#shellcheck#GetCommand(buffer, version_output) abort
|
|
|
|
let l:executable = ale_linters#sh#shellcheck#GetExecutable(a:buffer)
|
2017-11-09 23:42:54 +00:00
|
|
|
let l:version = ale#semver#GetVersion(l:executable, a:version_output)
|
2017-11-03 22:08:26 +00:00
|
|
|
|
2017-08-28 18:16:23 +00:00
|
|
|
let l:options = ale#Var(a:buffer, 'sh_shellcheck_options')
|
2017-04-29 18:57:34 +00:00
|
|
|
let l:exclude_option = ale#Var(a:buffer, 'sh_shellcheck_exclusions')
|
2017-08-28 18:16:23 +00:00
|
|
|
let l:dialect = ale_linters#sh#shellcheck#GetDialectArgument(a:buffer)
|
2017-11-09 23:42:54 +00:00
|
|
|
let l:external_option = ale#semver#GTE(l:version, [0, 4, 0]) ? ' -x' : ''
|
2017-04-27 22:01:01 +00:00
|
|
|
|
2017-10-25 23:48:51 +00:00
|
|
|
return ale#path#BufferCdString(a:buffer)
|
2017-11-03 22:08:26 +00:00
|
|
|
\ . ale#Escape(l:executable)
|
2017-09-22 21:37:12 +00:00
|
|
|
\ . (!empty(l:dialect) ? ' -s ' . l:dialect : '')
|
2017-08-28 18:16:23 +00:00
|
|
|
\ . (!empty(l:options) ? ' ' . l:options : '')
|
|
|
|
\ . (!empty(l:exclude_option) ? ' -e ' . l:exclude_option : '')
|
2017-11-03 22:08:26 +00:00
|
|
|
\ . l:external_option
|
|
|
|
\ . ' -f gcc -'
|
2016-10-27 08:20:22 +00:00
|
|
|
endfunction
|
|
|
|
|
2017-11-13 16:08:09 +00:00
|
|
|
function! ale_linters#sh#shellcheck#Handle(buffer, lines) abort
|
|
|
|
let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):(\d+)?:? ([^:]+): (.+)$'
|
|
|
|
let l:output = []
|
|
|
|
|
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
|
|
|
if l:match[4] is# 'error'
|
|
|
|
let l:type = 'E'
|
|
|
|
elseif l:match[4] is# 'note'
|
|
|
|
let l:type = 'I'
|
|
|
|
else
|
|
|
|
let l:type = 'W'
|
|
|
|
endif
|
|
|
|
|
|
|
|
let l:item = {
|
|
|
|
\ 'lnum': str2nr(l:match[2]),
|
|
|
|
\ 'type': l:type,
|
|
|
|
\ 'text': l:match[5],
|
|
|
|
\}
|
|
|
|
|
|
|
|
if !empty(l:match[3])
|
|
|
|
let l:item.col = str2nr(l:match[3])
|
|
|
|
endif
|
|
|
|
|
|
|
|
" If the filename is something like <stdin>, <nofile> or -, then
|
|
|
|
" this is an error for the file we checked.
|
|
|
|
if l:match[1] isnot# '-' && l:match[1][0] isnot# '<'
|
|
|
|
let l:item['filename'] = l:match[1]
|
|
|
|
endif
|
|
|
|
|
|
|
|
call add(l:output, l:item)
|
|
|
|
endfor
|
|
|
|
|
|
|
|
return l:output
|
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 18:51:29 +00:00
|
|
|
call ale#linter#Define('sh', {
|
2016-10-03 12:18:27 +00:00
|
|
|
\ 'name': 'shellcheck',
|
2017-04-09 17:54:25 +00:00
|
|
|
\ 'executable_callback': 'ale_linters#sh#shellcheck#GetExecutable',
|
2017-11-03 22:08:26 +00:00
|
|
|
\ 'command_chain': [
|
|
|
|
\ {'callback': 'ale_linters#sh#shellcheck#VersionCheck'},
|
|
|
|
\ {'callback': 'ale_linters#sh#shellcheck#GetCommand'},
|
|
|
|
\ ],
|
2017-11-13 16:08:09 +00:00
|
|
|
\ 'callback': 'ale_linters#sh#shellcheck#Handle',
|
2016-10-03 12:18:27 +00:00
|
|
|
\})
|