2016-10-04 19:10:12 +00:00
|
|
|
" Author: KabbAmine <amine.kabb@gmail.com>
|
|
|
|
" Description: This file adds support for checking HTML code with tidy.
|
|
|
|
|
2016-10-07 08:21:20 +00:00
|
|
|
" CLI options
|
|
|
|
let g:ale_html_tidy_executable = get(g:, 'ale_html_tidy_executable', 'tidy')
|
2018-05-28 18:52:27 +00:00
|
|
|
" remove in 2.0
|
2017-04-15 12:35:54 +00:00
|
|
|
" Look for the old _args variable first.
|
2018-05-28 18:52:27 +00:00
|
|
|
let s:deprecation_warning_echoed = 0
|
2017-04-15 12:35:54 +00:00
|
|
|
let s:default_options = get(g:, 'ale_html_tidy_args', '-q -e -language en')
|
|
|
|
let g:ale_html_tidy_options = get(g:, 'ale_html_tidy_options', s:default_options)
|
2016-10-07 08:21:20 +00:00
|
|
|
|
|
|
|
function! ale_linters#html#tidy#GetCommand(buffer) abort
|
2018-05-28 18:52:27 +00:00
|
|
|
" remove in 2.0
|
|
|
|
if exists('g:ale_html_tidy_args') && !s:deprecation_warning_echoed
|
|
|
|
execute 'echom ''Rename your g:ale_html_tidy_args setting to g:ale_html_tidy_options instead. Support for this will removed in ALE 2.0.'''
|
|
|
|
let s:deprecation_warning_echoed = 1
|
|
|
|
endif
|
|
|
|
|
2016-10-07 08:21:20 +00:00
|
|
|
" Specify file encoding in options
|
|
|
|
" (Idea taken from https://github.com/scrooloose/syntastic/blob/master/syntax_checkers/html/tidy.vim)
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:file_encoding = get({
|
2016-10-07 08:21:20 +00:00
|
|
|
\ 'ascii': '-ascii',
|
|
|
|
\ 'big5': '-big5',
|
|
|
|
\ 'cp1252': '-win1252',
|
|
|
|
\ 'cp850': '-ibm858',
|
|
|
|
\ 'cp932': '-shiftjis',
|
|
|
|
\ 'iso-2022-jp': '-iso-2022',
|
|
|
|
\ 'latin1': '-latin1',
|
|
|
|
\ 'macroman': '-mac',
|
|
|
|
\ 'sjis': '-shiftjis',
|
|
|
|
\ 'utf-16le': '-utf16le',
|
|
|
|
\ 'utf-16': '-utf16',
|
|
|
|
\ 'utf-8': '-utf8',
|
|
|
|
\ }, &fileencoding, '-utf8')
|
|
|
|
|
2018-01-02 16:42:08 +00:00
|
|
|
" On macOS, old tidy (released on 31 Oct 2006) is installed. It does not
|
|
|
|
" consider HTML5 so we should avoid it.
|
|
|
|
let l:executable = ale#Var(a:buffer, 'html_tidy_executable')
|
|
|
|
if has('mac') && l:executable is# 'tidy' && exists('*exepath')
|
|
|
|
\ && exepath(l:executable) is# '/usr/bin/tidy'
|
|
|
|
return ''
|
|
|
|
endif
|
|
|
|
|
2016-10-07 08:21:20 +00:00
|
|
|
return printf('%s %s %s -',
|
2018-01-02 16:42:08 +00:00
|
|
|
\ l:executable,
|
2017-04-16 00:24:08 +00:00
|
|
|
\ ale#Var(a:buffer, 'html_tidy_options'),
|
2016-10-10 23:43:45 +00:00
|
|
|
\ l:file_encoding
|
2017-04-15 12:35:54 +00:00
|
|
|
\)
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#html#tidy#GetExecutable(buffer) abort
|
2017-04-16 00:24:08 +00:00
|
|
|
return ale#Var(a:buffer, 'html_tidy_executable')
|
2016-10-07 08:21:20 +00:00
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#html#tidy#Handle(buffer, lines) abort
|
2016-10-04 19:10:12 +00:00
|
|
|
" Matches patterns lines like the following:
|
|
|
|
" line 7 column 5 - Warning: missing </title> before </head>
|
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:pattern = '^line \(\d\+\) column \(\d\+\) - \(Warning\|Error\): \(.\+\)$'
|
|
|
|
let l:output = []
|
2016-10-04 19:10:12 +00:00
|
|
|
|
2017-04-17 23:35:53 +00:00
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:line = l:match[1] + 0
|
|
|
|
let l:col = l:match[2] + 0
|
2017-08-08 07:39:13 +00:00
|
|
|
let l:type = l:match[3] is# 'Error' ? 'E' : 'W'
|
2016-10-10 23:43:45 +00:00
|
|
|
let l:text = l:match[4]
|
2016-10-04 19:10:12 +00:00
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
call add(l:output, {
|
|
|
|
\ 'lnum': l:line,
|
|
|
|
\ 'col': l:col,
|
|
|
|
\ 'text': l:text,
|
|
|
|
\ 'type': l:type,
|
2016-10-04 19:10:12 +00:00
|
|
|
\})
|
|
|
|
endfor
|
|
|
|
|
2016-10-10 23:43:45 +00:00
|
|
|
return l:output
|
2016-10-04 19:10:12 +00:00
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 18:51:29 +00:00
|
|
|
call ale#linter#Define('html', {
|
2016-10-07 08:21:20 +00:00
|
|
|
\ 'name': 'tidy',
|
2017-04-15 12:35:54 +00:00
|
|
|
\ 'executable_callback': 'ale_linters#html#tidy#GetExecutable',
|
2016-10-04 19:10:12 +00:00
|
|
|
\ 'output_stream': 'stderr',
|
2016-10-07 08:21:20 +00:00
|
|
|
\ 'command_callback': 'ale_linters#html#tidy#GetCommand',
|
2016-10-04 19:10:12 +00:00
|
|
|
\ 'callback': 'ale_linters#html#tidy#Handle',
|
2016-10-07 08:21:20 +00:00
|
|
|
\ })
|